Skip to content

Add initial status to drip destination #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stevedrip
Copy link

@stevedrip stevedrip commented Apr 25, 2025

The default behavior for status is a footgun for users. Prefer the more forgiving initial_status instead. When combined with status_updated_at this will updated a person's status as if the change happened at that timestamp. When status_updated_at is missing, any existing status will take priority.

Previously, we assumed that the user would always want to update the status when identifying a person. We defaulted to unsubscribing, and at the current timestamp. This has proven to be a poor assumption in practice. With this new behavior, if the status_updated_at was intended to be passed but missing, we won't modify the person's status in drip.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@stevedrip stevedrip marked this pull request as ready for review April 25, 2025 15:43
@stevedrip stevedrip requested a review from a team as a code owner April 25, 2025 15:43
@joe-ayoub-segment joe-ayoub-segment self-assigned this Apr 28, 2025
@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Apr 28, 2025

to @jacobpmeyer and Developer Rotation person - I'll take this PR so no need to follow up on it.

hi @stevedrip - thanks for the PR.
The code looks good. There is a failing test from another Integration though, so can you please pull in the latest code from Segment's main branch please?

Thank you!
Joe

@jacobpmeyer
Copy link
Contributor

to @jacobpmeyer and Developer Rotation person - I'll take this PR so no need to follow up on it.

hi @stevedrip - thanks for the PR. The code looks good. There is a failing test from another Integration though, so can you please pull in the latest code from Segment's main branch please?

Thank you! Joe

Hey @joe-ayoub-segment. I work with @stevedrip. I went ahead and merged main into this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants