Skip to content

Facebook custom audiences - Refactor #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joe-ayoub-segment wants to merge 36 commits into
base: main
Choose a base branch
from

adding default mappings

f4ce378
Select commit
Loading
Failed to load commit list.
Open

Facebook custom audiences - Refactor #3598

adding default mappings
f4ce378
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 4, 2026 in 1s

80.65% (target 70.00%)

View this Pull Request on Codecov

80.65% (target 70.00%)

Details

Codecov Report

❌ Patch coverage is 75.17730% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.65%. Comparing base (cfab928) to head (f4ce378).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...s/facebook-custom-audiences/sync/hook-functions.ts 17.14% 29 Missing ⚠️
...ations/facebook-custom-audiences/sync/functions.ts 83.44% 7 Missing and 17 partials ⚠️
...estinations/facebook-custom-audiences/functions.ts 81.66% 7 Missing and 4 partials ⚠️
...rc/destinations/facebook-custom-audiences/index.ts 82.35% 2 Missing and 1 partial ⚠️
...stinations/facebook-custom-audiences/sync/index.ts 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3598      +/-   ##
==========================================
+ Coverage   80.35%   80.65%   +0.29%     
==========================================
  Files        1309     1375      +66     
  Lines       23946    27310    +3364     
  Branches     4829     5804     +975     
==========================================
+ Hits        19243    22027    +2784     
- Misses       3807     4330     +523     
- Partials      896      953      +57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov