[Facebook Conversions API] Add ctwa_clid in user data of fb conversions apis#3601
Draft
harsh-joshi99 wants to merge 1 commit intomainfrom
Draft
[Facebook Conversions API] Add ctwa_clid in user data of fb conversions apis#3601harsh-joshi99 wants to merge 1 commit intomainfrom
harsh-joshi99 wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3601 +/- ##
=======================================
Coverage 80.31% 80.31%
=======================================
Files 1283 1283
Lines 23567 23569 +2
Branches 4726 4728 +2
=======================================
+ Hits 18928 18930 +2
Misses 3757 3757
Partials 882 882 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for Meta’s Click to WhatsApp Click ID (ctwa_clid) to the Facebook Conversions API destination by exposing it as a user_data field, normalizing it, and ensuring it is included in outgoing payloads.
Changes:
- Add
ctwa_clidto theuser_datainput field definition and include it in the serialized CAPIuser_datapayload. - Normalize
ctwa_clidby trimming whitespace. - Add unit tests across actions to assert
ctwa_clidis passed through inuser_data.
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/destination-actions/src/destinations/facebook-conversions-api/fb-capi-user-data.ts | Adds ctwa_clid field definition, trims it during normalization, and includes it in the outgoing user_data object. |
| packages/destination-actions/src/destinations/facebook-conversions-api/addToCart/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/addToCart2/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/custom/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/custom2/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/initiateCheckout/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/initiateCheckout2/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/pageView/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/pageView2/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/purchase/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/purchase2/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/search/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/search2/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/viewContent/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/viewContent2/generated-types.ts | Regenerates action payload types to include ctwa_clid in user_data. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/user-data.test.ts | Adds coverage verifying ctwa_clid is trimmed during normalization. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/addToCart.test.ts | Adds coverage verifying ctwa_clid is included in user_data for addToCart. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/addToCart2.test.ts | Adds coverage verifying ctwa_clid is included in user_data for addToCart2. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/custom.test.ts | Adds coverage verifying ctwa_clid is included in user_data for custom. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/custom2.test.ts | Adds coverage verifying ctwa_clid is included in user_data for custom2. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/initiateCheckout.test.ts | Adds coverage verifying ctwa_clid is included in user_data for initiateCheckout. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/initiateCheckout2.test.ts | Adds coverage verifying ctwa_clid is included in user_data for initiateCheckout2. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/pageView.test.ts | Adds coverage verifying ctwa_clid is included in user_data for pageView. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/pageView2.test.ts | Adds coverage verifying ctwa_clid is included in user_data for pageView2. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/purchase.test.ts | Adds coverage verifying ctwa_clid is included in user_data for purchase. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/purchase2.test.ts | Adds coverage verifying ctwa_clid is included in user_data for purchase2. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/search.test.ts | Adds coverage verifying ctwa_clid is included in user_data for search. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/search2.test.ts | Adds coverage verifying ctwa_clid is included in user_data for search2. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/viewContent.test.ts | Adds coverage verifying ctwa_clid is included in user_data for viewContent. |
| packages/destination-actions/src/destinations/facebook-conversions-api/tests/viewContent2.test.ts | Adds coverage verifying ctwa_clid is included in user_data for viewContent2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Meta’s Click to WhatsApp Click ID (ctwa_clid) to the Facebook Conversions API destination by exposing it as a user_data field, normalizing it, and ensuring it is included in outgoing payloads.
Changes:
Add ctwa_clid to the user_data input field definition and include it in the serialized CAPI user_data payload.
Normalize ctwa_clid by trimming whitespace.
Add unit tests across actions to assert ctwa_clid is passed through in user_data.
JIRA: https://twilio-engineering.atlassian.net/browse/STRATCONN-6454
Testing
Stage Testing Document
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example