[LR/TTD] Update meta.json structure to include audienceId, destinationConfigId and mappingId#3638
[LR/TTD] Update meta.json structure to include audienceId, destinationConfigId and mappingId#3638sayan-das-in wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3638 +/- ##
==========================================
+ Coverage 80.24% 80.44% +0.20%
==========================================
Files 1342 1316 -26
Lines 25481 24373 -1108
Branches 5268 4980 -288
==========================================
- Hits 20447 19607 -840
+ Misses 4112 3860 -252
+ Partials 922 906 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8c6ccd5 to
4d2b827
Compare
4d2b827 to
05836e4
Compare
| segmentInternal: { | ||
| audienceId?: string | ||
| destinationConfigId?: string | ||
| subscriptionId?: string | ||
| } |
There was a problem hiding this comment.
The PR title mentions "mappingId" as the third new field, but the code and PR description both use "subscriptionId". These should be consistent — if the field being added is named subscriptionId in code and described as subscriptionId in the PR description, the PR title should be updated to reflect that. This creates ambiguity about what subscriptionId refers to in the context of this integration.
There was a problem hiding this comment.
mappingId == subscriptionId
| RequeueCount: 0, | ||
| segmentInternal: expect.objectContaining({ | ||
| audienceId: expect.any(String), | ||
| destinationConfigId: expect.any(String), | ||
| subscriptionId: expect.any(String) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
The test at line 510-514 only asserts audienceId: expect.any(String), which allows an empty string. Since rawData is never passed in any of these new test cases, the actual extraction of audienceId from rawData[0].context?.personas?.computation_id is not being tested at all. To improve coverage, a test case should pass rawData containing a specific computation_id and assert that audienceId equals that value.
This PR modified the meta.json structure to include the following during Monoservice to Outbound Controller handoff.
Also addresses a field called
TTDAuthTokenwhich was incorrectly written asTDDAuthToken.To fix the typo, this change includes an additional duplicate field TTDAuthToken along with the old TDDAuthToken in meta.json. Once Outbound controller starts using the new value, this old value will be cleaned up.
Testing
Tested successfully in stage.
meta.json for The TradeDesk
meta.json for Liveramp
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example