Expose Message.totalSize, Message.size, and Message.headerSize#1337
Open
EvanMerlock wants to merge 1 commit into
Open
Expose Message.totalSize, Message.size, and Message.headerSize#1337EvanMerlock wants to merge 1 commit into
EvanMerlock wants to merge 1 commit into
Conversation
|
This feature would be very useful to me too! |
|
I would really like this too. Is there a reason why this is stalled? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the 3 functions
Message.totalSize,Message.size, andMessage.headerSizepublic.This is helpful for applications which may need to add a buffer before calling
WriteMessages, or for applications that need to compute the size of the payload on the wire for other reasons.Resolves #1254