fix: tester should fail when messages cannot be written #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petedannemann
commented
Mar 10, 2025
| Topic: testerConfig.topic, | ||
| Balancer: &kafka.LeastBytes{}, | ||
| Async: true, | ||
| QueueCapacity: 5, |
There was a problem hiding this comment.
QueueCapacity was deprecated and is no longer necessary
erushing
previously approved these changes
Mar 10, 2025
petedannemann
changed the title
hhahn-tw
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing messages,
testerused the async mode, which was unable of write errors. This switches that to send messages synchronously so that we can surface errors that come back from Kafka.