Call antehandlers for traceBlock #2139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
force-pushed
the
tony/fix-blocktrace
branch
3 times, most recently
from
e6ea1c7 to
ce7d076
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2139 +/- ##
==========================================
- Coverage 62.38% 62.27% -0.11%
==========================================
Files 293 295 +2
Lines 28937 29132 +195
==========================================
+ Hits 18052 18142 +90
- Misses 9556 9649 +93
- Partials 1329 1341 +12
🚀 New features to boost your workflow:
|
codchen
force-pushed
the
tony/fix-blocktrace
branch
3 times, most recently
from
09c8298 to
c84d9d7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1901
to
+1906
| go func() { | ||
| <-app.httpServerStartSignal | ||
| if err := evmHTTPServer.Start(); err != nil { | ||
| panic(err) | ||
| } | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
Comment on lines
+1914
to
+1919
| go func() { | ||
| <-app.wsServerStartSignal | ||
| if err := evmWSServer.Start(); err != nil { | ||
| panic(err) | ||
| } | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
codchen
force-pushed
the
tony/fix-blocktrace
branch
17 times, most recently
from
f3622cd to
d763001
Compare
codchen
force-pushed
the
tony/fix-blocktrace
branch
from
d763001 to
1157e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
There were two issues with how antehandlers are invoked during tracing:
debug_traceBlock...endpoints, which would specifically cause absence of address associationTesting performed to validate your change
patched on archive node