Fix truncated Telnet and TLS hello reads#2161
Open
ZX41R wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2161 +/- ##
==========================================
+ Coverage 82.72% 82.73% +0.01%
==========================================
Files 332 332
Lines 59807 59751 -56
Branches 12591 12302 -289
==========================================
- Hits 49475 49436 -39
- Misses 8947 8963 +16
+ Partials 1385 1352 -33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two parser accessors assumed optional bytes were present after the minimal message header:
The valid-packet path is unchanged. Truncated inputs now return the existing fallback values instead of reading past the available data.
Fixes #2151.
Fixes #2152.
Testing
I disabled LSAN for these runs because the test binary uses MemPlumber/backtrace allocation tracking; with leak detection enabled the tests themselves pass, then LSAN reports allocations from that tracking path at process exit.