Skip to content

Add nodegroup id to task #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n1Z3R merged 3 commits into from
Sep 10, 2025
Merged

Add nodegroup id to task #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
015f401
fix: add nodegroup id to task
n1Z3R Sep 10, 2025
02b5d4a
Merge branch 'selectel:master' into master
n1Z3R Sep 10, 2025
e2bfb5e
fix: task fixtures
n1Z3R Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/v1/task/schemas.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ type View struct {

// Task represents task's type.
Type Type `json:"-"`

// NodeGroupID contains node group identifier. It can be empty.
NodeGroupID string `json:"nodegroup_id,omitempty"`
}

func (result *View) UnmarshalJSON(b []byte) error {
Expand Down
48 changes: 27 additions & 21 deletions pkg/v1/task/testing/fixtures.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,17 @@ const testListTasksResponseRaw = `
"started_at": "2020-02-19T11:43:02.868387Z",
"status": "DONE",
"type": "NODE_GROUP_RESIZE",
"updated_at": "2020-02-19T11:43:02.868387Z"
"updated_at": "2020-02-19T11:43:02.868387Z",
"nodegroup_id":"9e714bc6-3815-4af5-9c94-f1560e87641a"
},
{
"cluster_id": "d2e16a48-a9c5-4449-9b71-81f21fc872db",
"id": "5f8fb93c-cf9e-4289-a78c-34393ac75f92",
"started_at": "2020-02-19T11:43:02.868387Z",
"status": "DONE",
"type": "NODE_REINSTALL",
"updated_at": "2020-02-19T11:43:02.868387Z"
"updated_at": "2020-02-19T11:43:02.868387Z",
"nodegroup_id":"9e714bc6-3815-4af5-9c94-f1560e87641a"
},
{
"cluster_id": "d2e16a48-a9c5-4449-9b71-81f21fc872db",
Expand Down Expand Up @@ -124,7 +126,8 @@ const testListTasksResponseRaw = `
"started_at": "2020-02-19T11:43:02.868387Z",
"status": "IN_PROGRESS",
"type": "UPDATE_NODEGROUP_LABELS",
"updated_at": "2020-02-19T11:43:02.868387Z"
"updated_at": "2020-02-19T11:43:02.868387Z",
"nodegroup_id":"9e714bc6-3815-4af5-9c94-f1560e87641a"
},
{
"cluster_id": "d2e16a48-a9c5-4449-9b71-81f21fc872db",
Expand Down Expand Up @@ -173,20 +176,22 @@ var expectedListTasksResponse = []*task.View{
Type: task.TypeRotateCerts,
},
{
ID: "4f8fb93c-cf9e-4289-a78c-34393ac75f92",
StartedAt: &taskResponseTimestamp,
UpdatedAt: &taskResponseTimestamp,
ClusterID: "d2e16a48-a9c5-4449-9b71-81f21fc872db",
Status: task.StatusDone,
Type: task.TypeNodeGroupResize,
ID: "4f8fb93c-cf9e-4289-a78c-34393ac75f92",
StartedAt: &taskResponseTimestamp,
UpdatedAt: &taskResponseTimestamp,
ClusterID: "d2e16a48-a9c5-4449-9b71-81f21fc872db",
Status: task.StatusDone,
Type: task.TypeNodeGroupResize,
NodeGroupID: "9e714bc6-3815-4af5-9c94-f1560e87641a",
},
{
ID: "5f8fb93c-cf9e-4289-a78c-34393ac75f92",
StartedAt: &taskResponseTimestamp,
UpdatedAt: &taskResponseTimestamp,
ClusterID: "d2e16a48-a9c5-4449-9b71-81f21fc872db",
Status: task.StatusDone,
Type: task.TypeNodeReinstall,
ID: "5f8fb93c-cf9e-4289-a78c-34393ac75f92",
StartedAt: &taskResponseTimestamp,
UpdatedAt: &taskResponseTimestamp,
ClusterID: "d2e16a48-a9c5-4449-9b71-81f21fc872db",
Status: task.StatusDone,
Type: task.TypeNodeReinstall,
NodeGroupID: "9e714bc6-3815-4af5-9c94-f1560e87641a",
},
{
ID: "6f8fb93c-cf9e-4289-a78c-34393ac75f92",
Expand All @@ -213,12 +218,13 @@ var expectedListTasksResponse = []*task.View{
Type: task.TypeUpgradeMinorVersion,
},
{
ID: "7f8fb93c-cf9e-4289-a78c-34393ac75f92",
StartedAt: &taskResponseTimestamp,
UpdatedAt: &taskResponseTimestamp,
ClusterID: "d2e16a48-a9c5-4449-9b71-81f21fc872db",
Status: task.StatusInProgress,
Type: task.TypeUpdateNodegroupLabels,
ID: "7f8fb93c-cf9e-4289-a78c-34393ac75f92",
StartedAt: &taskResponseTimestamp,
UpdatedAt: &taskResponseTimestamp,
ClusterID: "d2e16a48-a9c5-4449-9b71-81f21fc872db",
Status: task.StatusInProgress,
Type: task.TypeUpdateNodegroupLabels,
NodeGroupID: "9e714bc6-3815-4af5-9c94-f1560e87641a",
},
{
ID: "7f8fb93c-cf9e-4289-a78c-34393ac75f92",
Expand Down
Loading