docs(renovate-branches): define decision to not build renovate branches in test workflows#5
Open
travi wants to merge 2 commits into
Open
docs(renovate-branches): define decision to not build renovate branches in test workflows#5travi wants to merge 2 commits into
travi wants to merge 2 commits into
Conversation
…es in test workflows
HonkingGoose
left a comment
HonkingGoose
left a comment
Contributor
There was a problem hiding this comment.
I found some small things, that you might want to improve before you merge.
gr2m
reviewed
Nov 17, 2020
|
|
||
| In order for renovate PR branches to be built in isolation, they could be | ||
| included in the list under the `push` trigger in the test workflow as | ||
| `renovate/**`. However, that would result in duplication for the builds |
Member
There was a problem hiding this comment.
we might soon revert the decision as it looks like we will enable automergeType:branch as discussed at #3
If now pull requests are created, we will have to enable builds on push for the renovate branches
Member
Author
There was a problem hiding this comment.
yep, understood. just thought it would be a decent example of making a decision and later making a super-ceding decision. mostly just going through the motions, so i'm cool if we want to skip this one as wasteful
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initially implemented with semantic-release/github#306
while this may already be a decision that we end up changing, based on #3 (comment), we can follow up with another record that supersedes this decision