fix: under constrained bug binary merkle root - #1012
Merged
Conversation
* fix(circuits)!: update binary merkle root circuit version re #999 * chore: update snarkjs version from 0.7.4 to 0.7.5
refactor: update the proof package and smart contracts with new zk artifacts
fix: under constrained bug binary merkle root
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
NicoSerranoP
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
@zk-kit/binary-merkle-root.circomdependency to incorporate a recent bug fix from ZK-Kit.Details
Due to changes in the Semaphore circuit, a new Trusted Setup Ceremony is required. This PR includes the updated libraries along with the results of the staging ceremony.
Staging Trusted Setup Ceremony: https://pse-p0tion-staging.web.app/projects/Semaphore%20Binary%20Merkle%20Root%20Fix
Related Issue(s)
Closes #999
Checklist
yarn formatandyarn lintwithout getting any errorsImportant
We do not accept pull requests for minor grammatical fixes (e.g., correcting typos, rewording sentences) or for fixing broken links, unless they significantly improve clarity or functionality. These contributions, while appreciated, are not a priority for merging. If you notice any of these issues, please create a GitHub Issue to report them so they can be properly tracked and addressed.