Skip to content

Fix invalid components in Chakra UI - #964

Merged
vplasencia merged 8 commits into
semaphore-protocol:mainfrom
vipocenka:fix/fix
Aug 5, 2025
Merged

Fix invalid components in Chakra UI#964
vplasencia merged 8 commits into
semaphore-protocol:mainfrom
vipocenka:fix/fix

Conversation

@vipocenka

@vipocenka vipocenka commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Updated all remaining instances of align="left" to align="start" across all files and components:

  • page.tsx
  • projects/page.tsx
  • Carousel.tsx
  • InfoCard.tsx
  • ProjectsList.tsx
  • SectionBlock.tsx

@vplasencia vplasencia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vipocenka! Thank you very much for creating this PR. Could you update the remaining occurrences of align="left"?

@vipocenka

Copy link
Copy Markdown
Contributor Author

@vplasencia Hi!
Updated all remaining instances of align="left" to align="start" across all files and components:

  • page.tsx
  • projects/page.tsx
  • Carousel.tsx
  • InfoCard.tsx
  • ProjectsList.tsx
  • SectionBlock.tsx

@vplasencia vplasencia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vipocenka! Thank you very much for the updates. I just left two comments.

Comment thread apps/website/src/components/InfoCard.tsx Outdated
Comment thread apps/website/src/components/InfoCard.tsx Outdated
@vipocenka

Copy link
Copy Markdown
Contributor Author

Hi @vplasencia,
I've reverted the textAlign="start" back to textAlign="left" in the places you mentioned in InfoCard.tsx, as requested.
Let me know if there's anything else that needs adjustment.

@vplasencia vplasencia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vipocenka!

It looks great! Thank you for the updates. Could you update in InfoCard.tsx line 28 align="left" with align="start"?

@vipocenka

Copy link
Copy Markdown
Contributor Author

Hi @vplasencia!
Thanks for pointing that out — I’ve updated align="left" to align="start" in InfoCard.tsx on line 28 as requested. Let me know if there’s anything else I should adjust!

@vipocenka

Copy link
Copy Markdown
Contributor Author

Hi @vplasencia!

I’ve updated align="left" to align="start" on line 28 of InfoCard.tsx as requested. Could you please take another look and approve when you have a moment? Thanks! 🙏

@vplasencia vplasencia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vipocenka! It looks great! Thank you very much! 🚀

@vplasencia
vplasencia merged commit 53f4187 into semaphore-protocol:main Aug 5, 2025
4 checks passed
@gitpoap-bot

gitpoap-bot Bot commented Aug 5, 2025

Copy link
Copy Markdown

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Semaphore Contributor:

GitPOAP: 2025 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants