-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add proxy git client for repository cloning via Semaphore server #3260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
3
commits into
develop
Choose a base branch
from
copilot/fix-3259
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,8 @@ func CreateDefaultGitClient(keyInstaller AccessKeyInstaller) GitClient { | |
return CreateGoGitClient(keyInstaller) | ||
case util.CmdGitClientId: | ||
return CreateCmdGitClient(keyInstaller) | ||
case util.ProxyGitClientId: | ||
return CreateProxyGitClient(keyInstaller) | ||
default: | ||
return CreateCmdGitClient(keyInstaller) | ||
} | ||
|
@@ -24,3 +26,9 @@ func CreateCmdGitClient(keyInstaller AccessKeyInstaller) GitClient { | |
keyInstaller: keyInstaller, | ||
} | ||
} | ||
|
||
func CreateProxyGitClient(keyInstaller AccessKeyInstaller) GitClient { | ||
return ProxyGitClient{ | ||
keyInstaller: keyInstaller, | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Copilot Autofix
AI about 2 months ago
The best way to fix this problem is to ensure that any data containing sensitive fields—such as a Git URL that may have
username:password@hostname
—is either omitted, obfuscated, or carefully redacted before being logged. Specifically, when logging errors related to repository operations, we should avoid logging sensitive values, or sanitize the error and associated fields before logging.In this case, the problematic log line is:
The
err
itself may include the sensitive password, andreq.GitURL
is known-safe (doesn't include credentials), but downstream errors (originating from e.g., constructed clone URLs with credentials) could inject sensitive data.To fix:
err.Error()
before logging:Implementation:
api/runners/runners.go
.