feat(#3713): add template search on GUI#3945
Open
sickwell6988 wants to merge 3 commits into
Open
Conversation
Add a client-side search for Task Templates with a search field, live case-insensitive filtering, live result count and an empty-state message
This reverts commit ed006a2.
Add a client-side search for Task Templates with a search field, live case-insensitive filtering, live result count and an empty-state message
There was a problem hiding this comment.
Security review — PR #3945
Scope: feat(#3713): add template search on GUI (client-side template name filter in Templates.vue + i18n strings).
Prior automation threads: None found; nothing to reconcile.
Outcome: No medium, high, or critical vulnerabilities identified in the added/modified code.
What was reviewed
- Attack surface: New
searchstate bound to av-text-field; used only for client-side filtering (filterByName,filteredItems) and UI copy (noResultsText,xOfYTemplates). - Backend / auth: No API, permission, or routing changes. Templates are still loaded via existing authenticated endpoints in
ItemListPageBase; search does not fetch or expose additional data. - XSS (primary candidate):
noResultsTextinterpolates user input intonoTemplatesMatchSearch, but the result is passed to Vuetifyv-data-table:no-results-text, which renders it as a plain text child in a<td>(notv-html). Vue text rendering escapes HTML, so a payload like<img onerror=alert(1)>is displayed literally, not executed. ThexOfYTemplatescounter only passes numeric counts. - Other classes: No injection sinks, SSRF, path traversal, deserialization, secret logging, or dependency changes in this diff.
No action required from a security standpoint for this change set.
Sent by Cursor Automation: Find vulnerabilities
Collaborator
Author
|
#3713 - covers partially this |
Collaborator
Author
|
Decided not to modify API, just modify GUI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Add a client-side search for Task Templates with a search field, live case-insensitive filtering, live result count and an empty-state message]