elixir allows ellipsis in keyword/pair positions #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something having to do with CircleCI's config causing the workflow to fail. Locally ran |
amchiclet
requested review from
mjambon,
IagoAbal,
aryx and
brandonspark
and removed request for
a team,
IagoAbal and
mjambon
1 task
amchiclet
added a commit
that referenced
this pull request
Jan 16, 2024
Elixir already has ellipsis, but it expects them where identifiers are expected.
But Semgrep also wants to allow ellipsis in other places. This PR allows ellipsis
where keyword/pairs are expected.
Such as function calls foo(kwd_arg1: 0, ...) or map items %{item1: 0, ...}.
Previously, these cases won't parse.
Tested with make test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elixir already has ellipsis, but it expects them where identifiers are expected.
But Semgrep also wants to allow ellipsis in other places. This PR allows ellipsis
where keyword/pairs are expected.
Such as function calls
foo(kwd_arg1: 0, ...)or map items%{item1: 0, ...}.Previously, these cases won't parse.
Tested with
make test.Security