Update julia grammar #520
Open
Update julia grammar #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Julia grammar to tree-sitter-julia#135. That PR introduced several breaking changes, including changes in the way function signatures and parameters were parsed.
|
|
aryx
reviewed
Jan 9, 2025
| ), | ||
|
|
||
| _statement: ($, previous) => choice( | ||
| previous, | ||
| $.semgrep_ellipsis, | ||
| ), | ||
|
|
||
| typed_parameter: ($, previous) => choice( |
There was a problem hiding this comment.
Why removing this? We can still have ellpisis in type parameters even with this removal?
There was a problem hiding this comment.
Julia doesn't have a distinction between expressions and patterns, so function signatures are parsed as function calls, and checked in the lowering phase (after macro expansion). Having these parameter rules added a lot of duplication and conflicts, so we removed them.
We can still have ellpisis in type parameters even with this removal?
Yes. Ellipsis would now be parsed as splat_expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Julia grammar to tree-sitter/tree-sitter-julia#135. That PR introduced several breaking changes, including changes in the way function signatures and parameters were parsed.
(This should reduce the size of the
parser.cin semgrep-julia by about 15MB).Checklist