Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update info re: Assistant memories and noise filtering #1903

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

khorne3
Copy link
Collaborator

@khorne3 khorne3 commented Jan 13, 2025

Previews:

Please ensure

  • A subject matter expert (SME) reviews the content
  • A technical writer reviews the content or PR

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for semgrep-docs-prod failed. Why did it fail? →

Name Link
🔨 Latest commit 44743e2
🔍 Latest deploy log https://app.netlify.com/sites/semgrep-docs-prod/deploys/67881a2222d6960008960e08

@khorne3 khorne3 changed the title Katiehorne/tec 242 noise filter for code prmr comments assistant update info re: Assistant memories and noise filtering Jan 13, 2025
Copy link
Collaborator

@jsmoxon jsmoxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! Left a few comments. We can also cover in the dry run tomorrow.

docs/semgrep-assistant/overview.md Outdated Show resolved Hide resolved
docs/semgrep-assistant/getting-started.md Outdated Show resolved Hide resolved
@khorne3 khorne3 marked this pull request as ready for review January 15, 2025 17:11
@khorne3 khorne3 requested a review from jsmoxon January 15, 2025 17:11

Security teams can review filtered findings at any time on Semgrep's [**Code > Pre-production** page](https://semgrep.dev/orgs/-/findings?tab=open&last_opened=All+time&backlog=preprod). Semgrep also allows you to agree or disagree with the filtering. If you agree with the suggestion, Semgrep closes the finding, but if you disagree, Semgrep reopens the finding.

Assistant is over 95% accurate in categorizing Semgrep Code findings as false positives.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@jsmoxon jsmoxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment about a link. Looks good!

@khorne3 khorne3 requested a review from s-santillan January 15, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants