Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for ADO SMS #1910

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

khorne3
Copy link
Collaborator

@khorne3 khorne3 commented Jan 16, 2025

Preview

Please ensure

  • A subject matter expert (SME) reviews the content
  • A technical writer reviews the content or PR

Copy link

netlify bot commented Jan 16, 2025

Don't forget to add /docs at the end of the deploy preview site URL!

Name Link
🔨 Latest commit 7a804d4
🔍 Latest deploy log https://app.netlify.com/sites/semgrep-docs-prod/deploys/678a6cc1c4f8f400089c3651
😎 Deploy Preview https://deploy-preview-1910--semgrep-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@khorne3 khorne3 marked this pull request as ready for review January 17, 2025 14:44
@khorne3 khorne3 requested a review from zyannes January 17, 2025 14:44
## Prerequisites and permissions

- Semgrep Managed Scanning requires repositories hosted by Azure DevOps Services. It currently doesn't support Azure DevOps Server.
- Semgrep recommends setting up and configuring Semgrep Managed Scanning with an Azure DevOps service account instead of a personal account. Regardless of whether you use a personal or service account, the account must be assigned the **Owner** or **Project Collection Administrator** role for the organization.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Semgrep recommends setting up and configuring Semgrep Managed Scanning with an Azure DevOps service account instead of a personal account. Regardless of whether you use a personal or service account, the account must be assigned the **Owner** or **Project Collection Administrator** role for the organization.
- Semgrep recommends setting up and configuring Semgrep Managed Scanning with an Azure DevOps service account, not a personal account. Regardless of whether you use a personal or service account, the account must be assigned the **Owner** or **Project Collection Administrator** role for the organization.

Suggesting "not" for emphasis.

- Semgrep Managed Scanning requires repositories hosted by Azure DevOps Services. It currently doesn't support Azure DevOps Server.
- Semgrep recommends setting up and configuring Semgrep Managed Scanning with an Azure DevOps service account instead of a personal account. Regardless of whether you use a personal or service account, the account must be assigned the **Owner** or **Project Collection Administrator** role for the organization.
- During setup and configuration, you must provide a personal access token generated by the account. This token must be granted the **Project and Team: Read & write** scope.
- Once you have Managed Scanning fully configured, you can update the token to one with a more limited scope, specifically **Project and Team: Read**.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Once you have Managed Scanning fully configured, you can update the token to one with a more limited scope, specifically **Project and Team: Read**.
- Once you have Managed Scanning fully configured, you can update the token to **Project and Team: Read**, a more limited scope.

Just being more direct with the token scope. Feel free to ignore.

- During setup and configuration, you must provide a personal access token generated by the account. This token must be granted the **Project and Team: Read & write** scope.
- Once you have Managed Scanning fully configured, you can update the token to one with a more limited scope, specifically **Project and Team: Read**.

## Enable Managed Scanning and scan your first repository
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Enable Managed Scanning and scan your first repository
## Enable Managed Scans and scan your first repository

1. In Semgrep AppSec Platform, click **<i class="fa-solid fa-folder-open"></i> Projects**.
2. Click **Scan new project > Semgrep Managed Scan**.
3. Select **Azure Devops** as your source code manager.
4. On the **Add to Azure DevOps Pipeline** page, provide the following information, then click **Connect** to proceed:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. On the **Add to Azure DevOps Pipeline** page, provide the following information, then click **Connect** to proceed:
4. On the **Add to Azure DevOps Pipeline** page, provide the following information:

4. On the **Add to Azure DevOps Pipeline** page, provide the following information, then click **Connect** to proceed:
1. Your **Access token**. See [User personal access tokens](https://learn.microsoft.com/en-us/azure/devops/organizations/accounts/use-personal-access-tokens-to-authenticate) for token generation information. Ensure you set the Azure DevOps SCM name to `organization_name/project_name`.
2. The name of your **Azure DevOps Project**.
<!-- vale on -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- vale on -->
5. Click **Connect** to proceed.
<!-- vale on -->

Making Connect its own step so that people don't miss it.

If you plan to continue running some scans in Azure DevOps Pipelines (for example, using Managed Scans to run weekly full scans but Pipelines for diff-aware scans) you can leave the workflow file in place, and edit it to reflect your desired configuration.

:::tip
Semgrep preserves your findings, scans, and triage history.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So important. Thanks for calling this out.


<ScanWithSms />

## Disable webhooks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they disable the webhooks, that disables managed scanning then, right?


### Scan logs

#### Most recent scan
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm foreseeing a snippetified world when we have many of these SCMs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants