Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/update instructions for Secrets PR comments #1990

Conversation

khorne3
Copy link
Collaborator

@khorne3 khorne3 commented Feb 26, 2025

  • Updated _comment-triggers.mdx to remove mentions of Secrets in beta and to link to new contect sections
  • Created a new component on rules for Secrets comments /procedure/_pr-comments-in-secrets.mdx
  • Updated links on the SCM-specific pages to use components

Preview of changes on the ADO doc

Please ensure

  • A subject matter expert (SME) reviews the content
  • A technical writer reviews the content or PR

Copy link

netlify bot commented Feb 26, 2025

Don't forget to add /docs at the end of the deploy preview site URL!

Name Link
🔨 Latest commit e1d1ab0
🔍 Latest deploy log https://app.netlify.com/sites/semgrep-docs-prod/deploys/67dad7edb9b4990008d4b382
😎 Deploy Preview https://deploy-preview-1990--semgrep-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@khorne3 khorne3 marked this pull request as ready for review February 26, 2025 16:27
@s-santillan
Copy link
Collaborator

@khorne3 It looks like the component was applied to Code?
image

Copy link
Collaborator

@s-santillan s-santillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@s-santillan
Copy link
Collaborator

@khorne3 Really sorry but it looks like some updates have caused conflicts.

@khorne3
Copy link
Collaborator Author

khorne3 commented Mar 13, 2025

@s-santillan no worries -- I'll leave this be until I can get more information, and then I will fix all the things

Copy link
Contributor

@LewisArdern LewisArdern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments, otherwise :lgtm: 🙇

hit me up in slack to discuss if you need more info

@khorne3 khorne3 merged commit 8d30080 into main Mar 19, 2025
7 checks passed
@khorne3 khorne3 deleted the katiehorne/tec-282-update-secrets-instructions-on-comment-trigger-table branch March 19, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants