Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional step to webhook setup guide for enabling broker #2059

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Add optional step to webhook setup guide for enabling broker #2059

merged 2 commits into from
Mar 28, 2025

Conversation

matthewdean-semgrep
Copy link
Contributor

@matthewdean-semgrep matthewdean-semgrep commented Mar 27, 2025 •
edited
Loading

Thanks for improving Semgrep Docs 😀

Please ensure

  • A subject matter expert (SME) reviews the content
  • A technical writer reviews the content or PR

@matthewdean-semgrep matthewdean-semgrep requested a review from a team March 27, 2025 19:59
@netlify Netlify
Copy link

netlify bot commented Mar 27, 2025 •
edited
Loading

✅ Don't forget to add /docs at the end of the deploy preview site URL!

Name Link
🔨 Latest commit ef4d100
🔍 Latest deploy log https://app.netlify.com/sites/semgrep-docs-prod/deploys/67e6d9b8d7d9f700089cdb8d
😎 Deploy Preview https://deploy-preview-2059--semgrep-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

s-santillan
s-santillan approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@s-santillan s-santillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit only! Approved. Thank you.

@matthewdean-semgrep
Copy link
Contributor Author

matthewdean-semgrep commented Mar 28, 2025 •
edited
Loading

@s-santillan Applied your proposed changes. Will merge this once the feature goes live.

@matthewdean-semgrep matthewdean-semgrep merged commit 91845e9 into main Mar 28, 2025
7 checks passed
@matthewdean-semgrep matthewdean-semgrep deleted the matthewdean/webhook-broker-instructions branch March 28, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-santillan s-santillan s-santillan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewdean-semgrep @s-santillan