Skip to content

Commit

Permalink
Remove some useless deriving yojson (#319)
Browse files Browse the repository at this point in the history
- [x] I ran `make setup && make` to update the generated code after
editing a `.atd` file (TODO: have a CI check)
- [x] I made sure we're still backward compatible with old versions of
the CLI.
For example, the Semgrep backend need to still be able to *consume* data
generated
	  by Semgrep 1.17.0.
See
https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
  • Loading branch information
aryx authored Dec 3, 2024
1 parent 7c28436 commit 19cecc6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion semgrep_output_v1.atd
Original file line number Diff line number Diff line change
Expand Up @@ -1932,7 +1932,7 @@ type lockfile_kind
] <ocaml repr="classic">

type manifest_kind
<ocaml attr="deriving show, eq, yojson">
<ocaml attr="deriving show, eq">
<python decorator="dataclass(frozen=True)"> = [
| RequirementsIn
(* A Pip Requirements.in in file, which follows the format of requirements.txt - https://pip.pypa.io/en/stable/reference/requirements-file-format/ *)
Expand Down
3 changes: 1 addition & 2 deletions semgrep_output_v1_j.ml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions semgrep_output_v1_j.mli

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 19cecc6

Please sign in to comment.