Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run lint in container #172

Merged
merged 17 commits into from
Nov 7, 2023
Merged

run lint in container #172

merged 17 commits into from
Nov 7, 2023

Conversation

jbergler
Copy link
Contributor

@jbergler jbergler commented Oct 25, 2023

Now that the required version of atddiff is available in our base ocaml container, we can use that for much faster runs.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Backwards compatability summary:

Checking backward compatibility of semgrep_output_v1.atd against past version v1.16.0
Skipping v1.17.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.17.1 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.18.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.19.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.20.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.21.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.22.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.23.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.24.0
Skipping v1.24.1 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.25.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.26.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.27.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.28.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.29.0
Skipping v1.30.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.1 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.2 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.32.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.33.0
Skipping v1.33.1 because commit 8849e56ddb0977e38a120a6cfbd1c396eb6fa15e has already been checked
Skipping v1.33.2 because commit 8849e56ddb0977e38a120a6cfbd1c396eb6fa15e has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.34.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.37.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.38.0
Skipping v1.38.1 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Skipping v1.38.2 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Skipping v1.38.3 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.39.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.40.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.41.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.42.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.43.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.44.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.45.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.46.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.47.0
Skipping v1.48.0 because commit 278ed753e0c66b8bfc3f2d805fde53be022dd4b6 has already been checked

@jbergler jbergler requested a review from mjambon October 25, 2023 02:52
@jbergler
Copy link
Contributor Author

We can try and re-run the job when the docker image has the right version of atddiff in it.

@jbergler jbergler marked this pull request as draft November 7, 2023 18:05
@jbergler jbergler marked this pull request as ready for review November 7, 2023 19:05
@jbergler jbergler merged commit a0b4762 into main Nov 7, 2023
@jbergler jbergler deleted the jbergler/linting branch November 7, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant