Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add additional internal pattern combinator #180

Merged
merged 3 commits into from
Nov 8, 2023
Merged

feat: add additional internal pattern combinator #180

merged 3 commits into from
Nov 8, 2023

Conversation

kopecs
Copy link
Contributor

@kopecs kopecs commented Nov 3, 2023

Allows semgrep-internal-patterns-allow-disjoint to appear everywhere (other than taint) where a patterns may appear. See notion for semantics.

@kopecs kopecs requested a review from akuhlens November 3, 2023 20:19
@linear Linear
Copy link

linear bot commented Nov 3, 2023

SCRT-233 Update rule schema for `semgrep-internal-patterns-allow-disjoint`

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

Backwards compatability summary:

Checking backward compatibility of semgrep_output_v1.atd against past version v1.16.0
Skipping v1.17.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.17.1 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.18.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.19.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.20.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.21.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.22.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.23.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.24.0
Skipping v1.24.1 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.25.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.26.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.27.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.28.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.29.0
Skipping v1.30.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.1 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.2 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.32.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.33.0
Skipping v1.33.1 because commit 8849e56ddb0977e38a120a6cfbd1c396eb6fa15e has already been checked
Skipping v1.33.2 because commit 8849e56ddb0977e38a120a6cfbd1c396eb6fa15e has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.34.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.37.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.38.0
Skipping v1.38.1 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Skipping v1.38.2 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Skipping v1.38.3 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.39.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.40.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.41.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.42.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.43.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.44.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.45.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.46.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.47.0
Skipping v1.48.0 because commit 278ed753e0c66b8bfc3f2d805fde53be022dd4b6 has already been checked

aryx
aryx reviewed Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@aryx aryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is that? Is there some doc about it and about its motivation?

@kopecs
Copy link
Contributor Author

kopecs commented Nov 3, 2023

Yep - see https://www.notion.so/semgrep/semgrep-internal-patterns-allow-disjoint-bd56b763e470494bba9213523c45a5cf?pvs=4

@kopecs kopecs force-pushed the cooper/scrt-233-update-rule-schema-for-semgrep-internal-patterns-allow branch from 1367a74 to bed2f96 Compare November 8, 2023 18:10
@kopecs kopecs requested a review from aryx November 8, 2023 18:10
aryx
aryx approved these changes Nov 8, 2023
View reviewed changes
rule_schema_v1.yaml Outdated Show resolved Hide resolved
kopecs added 3 commits November 8, 2023 14:29
@kopecs
Add additional internal pattern combinator
a12009e 
Allows `semgrep-internal-patterns-allow-disjoint` to appear everywhere
(other than taint) where a `patterns` may appear. See notion for
semantics.
@kopecs
Rename based on discussion
d036762
@kopecs
Update matching explanations
a9de831
@kopecs kopecs force-pushed the cooper/scrt-233-update-rule-schema-for-semgrep-internal-patterns-allow branch from bed2f96 to a9de831 Compare November 8, 2023 22:30
@kopecs kopecs requested a review from emjin November 8, 2023 23:16
@kopecs kopecs merged commit ad4eb72 into main Nov 8, 2023
@kopecs kopecs deleted the cooper/scrt-233-update-rule-schema-for-semgrep-internal-patterns-allow branch November 8, 2023 23:58
aryx
aryx reviewed Nov 9, 2023
View reviewed changes
semgrep_output_v1.atd
@@ -685,6 +685,7 @@ type matching_operation <ocaml attr="deriving show { with_path = false}"> = [
| And
| Or
| Inside
| Anywhere
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually try to indicate when something was introduced, like (* since semgrep 1.49 *)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put up another PR to add a note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryx aryx aryx approved these changes

@akuhlens akuhlens Awaiting requested review from akuhlens

@emjin emjin Awaiting requested review from emjin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kopecs @CLAassistant @aryx