Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify rule_schema_v2.atd, use less variant #187

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

aryx
Copy link
Collaborator

@aryx aryx commented Nov 9, 2023

This better match the syntax.
The goal is not to redo Rule.ml and have clean variant types!
The goal is to specify the syntax.

test plan:
see related PR in semgrep

This better match the syntax.
The goal is not to redo Rule.ml and have clean variant types!
The goal is to specify the syntax.

test plan:
see related PR in semgrep
@aryx aryx requested review from a team, akuhlens, IagoAbal and brandonspark and removed request for a team November 9, 2023 10:54
Copy link

github-actions bot commented Nov 9, 2023

Backwards compatability summary:

Checking backward compatibility of semgrep_output_v1.atd against past version v1.16.0
Skipping v1.17.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.17.1 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.18.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.19.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.20.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.21.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.22.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.23.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.24.0
Skipping v1.24.1 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.25.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.26.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.27.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.28.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.29.0
Skipping v1.30.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.1 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.2 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.32.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.33.0
Skipping v1.33.1 because commit 8849e56ddb0977e38a120a6cfbd1c396eb6fa15e has already been checked
Skipping v1.33.2 because commit 8849e56ddb0977e38a120a6cfbd1c396eb6fa15e has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.34.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.37.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.38.0
Skipping v1.38.1 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Skipping v1.38.2 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Skipping v1.38.3 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.39.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.40.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.41.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.42.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.43.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.44.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.45.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.46.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.47.0
Skipping v1.48.0 because commit 278ed753e0c66b8bfc3f2d805fde53be022dd4b6 has already been checked

@aryx aryx requested a review from kopecs November 9, 2023 11:07
@aryx aryx merged commit e655eef into main Nov 9, 2023
@aryx aryx deleted the better_v2_atd_less_variant branch November 9, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant