Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mypy issues after #202 #204

Merged
merged 2 commits into from
Dec 22, 2023
Merged

fix: mypy issues after #202 #204

merged 2 commits into from
Dec 22, 2023

Conversation

kopecs
Copy link
Contributor

@kopecs kopecs commented Dec 21, 2023

See https://semgrepinc.slack.com/archives/C01NXGX2EHZ/p1703115761745179

@kopecs kopecs requested a review from amchiclet December 21, 2023 01:14
Copy link

github-actions bot commented Dec 21, 2023

Backwards compatability summary:

Checking backward compatibility of semgrep_output_v1.atd against past version v1.16.0
Skipping v1.17.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.17.1 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.18.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.19.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.20.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.21.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Skipping v1.22.0 because commit efc8e5c0076c8d460c0f802bc1fb2732490d0103 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.23.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.24.0
Skipping v1.24.1 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.25.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.26.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Skipping v1.27.0 because commit 213f67abea73546ca6111e1bbf0ef96aa917c940 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.28.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.29.0
Skipping v1.30.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.1 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.2 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.32.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.33.0
Skipping v1.33.1 because commit 8849e56ddb0977e38a120a6cfbd1c396eb6fa15e has already been checked
Skipping v1.33.2 because commit 8849e56ddb0977e38a120a6cfbd1c396eb6fa15e has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.34.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.37.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.38.0
Skipping v1.38.1 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Skipping v1.38.2 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Skipping v1.38.3 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.39.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.40.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.41.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.42.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.43.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.44.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.45.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.46.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.47.0
Skipping v1.48.0 because commit 278ed753e0c66b8bfc3f2d805fde53be022dd4b6 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.49.0
Skipping v1.50.0 because commit 857682f41eb09e0b330a247ff1adf3bfeaf9d9ca has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.52.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.53.0
Skipping v1.54.0 because commit 3b72d494260258497e796d094b1a4916501a6df1 has already been checked
Skipping v1.54.1 because commit 3b72d494260258497e796d094b1a4916501a6df1 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.54.2

aryx
aryx previously requested changes Dec 21, 2023
semgrep_metrics.atd Outdated Show resolved Hide resolved
@aryx aryx requested review from jbergler and mmcqd December 21, 2023 07:31
semgrep_metrics.atd Outdated Show resolved Hide resolved
@kopecs kopecs requested a review from aryx December 21, 2023 18:29
@kopecs kopecs dismissed aryx’s stale review December 21, 2023 18:30

Typo fixed

Copy link
Contributor

@amchiclet amchiclet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@kopecs kopecs merged commit 6dffeaa into main Dec 22, 2023
2 checks passed
@kopecs kopecs deleted the cooper/fix-metrics branch December 22, 2023 19:14
kopecs added a commit to semgrep/semgrep that referenced this pull request Dec 22, 2023
Updates semgrep interfaces and fixes typing issues related to stale
artefacts (semgrep_metrics.py). See
semgrep/semgrep-interfaces#204.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants