-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a metric to record how many interface fields are resolved #294
Conversation
Backwards compatibility summary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to be convinved there is a used for those metrics; otherwise not
worth the added complexity.
semgrep_metrics.atd
Outdated
* in the input source code. | ||
* Since semgrep 1.91 | ||
*) | ||
?numInterfaceVarResolved <ocaml mutable>: int option; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to collect such metrics. If you're interested in improving our name resolution, just do some benchmarks and extend the metrics in Stat_code.ml (which is used in Graph_code_SIG_SAST.ml for example).
Let's say we collect those metrics, what will you do based on the value?
This PR is for https://github.com/semgrep/semgrep-proprietary/pull/2345
make setup && make
to update the generated code after editing a.atd
file (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data generated
by Semgrep 1.17.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades