Adding Move on Sui to languages #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryx
approved these changes
Oct 10, 2024
| id_string = "move_on_sui"; | ||
| name = "Move on Sui"; | ||
| keys = [{|move_on_sui|}]; | ||
| exts = [{|.move|}]; |
There was a problem hiding this comment.
@mjambon will this be problematic that we now have 2 languages (move_on_sui, move_on_aptos) using the same .move extension? Not sure how file targeting will work.
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Oct 10, 2024
Move on Sui was [added recently](semgrep/semgrep-interfaces#296). My guess is that it may be the exact same language as Move on Aptos, but I'm not sure. I stubbed out everything with `failwith "Unimplemented"` for now, so that other interface changes can move forward without waiting for proper handling of Move on Sui. Test plan: wait for CI. synced from Pro 5fb80dfd435b0dc169d82c6eb2367c981122a08e
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Oct 11, 2024
Move on Sui was [added recently](semgrep/semgrep-interfaces#296). My guess is that it may be the exact same language as Move on Aptos, but I'm not sure. I stubbed out everything with `failwith "Unimplemented"` for now, so that other interface changes can move forward without waiting for proper handling of Move on Sui. Test plan: wait for CI. synced from Pro 5fb80dfd435b0dc169d82c6eb2367c981122a08e
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Oct 11, 2024
Move on Sui was [added recently](semgrep/semgrep-interfaces#296). My guess is that it may be the exact same language as Move on Aptos, but I'm not sure. I stubbed out everything with `failwith "Unimplemented"` for now, so that other interface changes can move forward without waiting for proper handling of Move on Sui. Test plan: wait for CI. synced from Pro 5fb80dfd435b0dc169d82c6eb2367c981122a08e
emjin
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Oct 11, 2024
Move on Sui was [added recently](semgrep/semgrep-interfaces#296). My guess is that it may be the exact same language as Move on Aptos, but I'm not sure. I stubbed out everything with `failwith "Unimplemented"` for now, so that other interface changes can move forward without waiting for proper handling of Move on Sui. Test plan: wait for CI. synced from Pro 5fb80dfd435b0dc169d82c6eb2367c981122a08e
aryx
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Oct 16, 2024
This adds initial support for the Sui version of Move to Semgrep. While this is an initial commit, a large portion of the language works. Metavariables work, etc. The big thing missing is support for annotations (eg #test). This support will be added after it is added to upstream move tree-sitter. Note: This PR depends on: semgrep/ocaml-tree-sitter-semgrep#515 to merge (and a new [semgrep-move-on-sui] to be pushed). And semgrep/semgrep-interfaces#296 which adds move-on-sui to the languages.
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Oct 16, 2024
…y#10589) (semgrep/semgrep-proprietary#2425) This adds initial support for the Sui version of Move to Semgrep. While this is an initial commit, a large portion of the language works. Metavariables work, etc. The big thing missing is support for annotations (eg #test). This support will be added after it is added to upstream move tree-sitter. Note: This PR depends on: semgrep/ocaml-tree-sitter-semgrep#515 to merge (and a new [semgrep-move-on-sui] to be pushed). And semgrep/semgrep-interfaces#296 which adds move-on-sui to the languages. sync of #10589 synced from Pro fb54fceb72e1ff76440496c15fb70bb01ec2b687
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Oct 17, 2024
…y#10589) (semgrep/semgrep-proprietary#2425) This adds initial support for the Sui version of Move to Semgrep. While this is an initial commit, a large portion of the language works. Metavariables work, etc. The big thing missing is support for annotations (eg #test). This support will be added after it is added to upstream move tree-sitter. Note: This PR depends on: semgrep/ocaml-tree-sitter-semgrep#515 to merge (and a new [semgrep-move-on-sui] to be pushed). And semgrep/semgrep-interfaces#296 which adds move-on-sui to the languages. sync of #10589 synced from Pro fb54fceb72e1ff76440496c15fb70bb01ec2b687
aryx
added a commit
to semgrep/semgrep
that referenced
this pull request
Oct 17, 2024
…y#10589) (semgrep/semgrep-proprietary#2425) This adds initial support for the Sui version of Move to Semgrep. While this is an initial commit, a large portion of the language works. Metavariables work, etc. The big thing missing is support for annotations (eg #test). This support will be added after it is added to upstream move tree-sitter. Note: This PR depends on: semgrep/ocaml-tree-sitter-semgrep#515 to merge (and a new [semgrep-move-on-sui] to be pushed). And semgrep/semgrep-interfaces#296 which adds move-on-sui to the languages. sync of #10589 synced from Pro fb54fceb72e1ff76440496c15fb70bb01ec2b687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data generated
by Semgrep 1.17.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
I assume that adding a new language is backwards compatiable?