-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lockfileless): Added rest of ManifestKinds
#301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManifestKinds
Backwards compatibility summary:
|
bkettle
approved these changes
Oct 24, 2024
salolivares
reviewed
Oct 24, 2024
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Oct 31, 2024
…rep/semgrep-proprietary#2483) semgrep/semgrep-interfaces#301 adds additional manifest kinds to `semgrep-interfaces`. This PR makes the necessary changes in the OCaml code to support the new interfaces. No functionality change, so existing tests are used. synced from Pro e97820974fc014e53ac806072853566796af515c
ajbt200128
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Oct 31, 2024
…rep/semgrep-proprietary#2483) semgrep/semgrep-interfaces#301 adds additional manifest kinds to `semgrep-interfaces`. This PR makes the necessary changes in the OCaml code to support the new interfaces. No functionality change, so existing tests are used. synced from Pro e97820974fc014e53ac806072853566796af515c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the rest of the manifest kinds we support to the
ManifestKind
type's possible values.make setup && make
to update the generated code after editing a.atd
file (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data generated
by Semgrep 1.17.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades