Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format_context and complete output_format for RPC call to format #310

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

aryx
Copy link
Collaborator

@aryx aryx commented Nov 6, 2024

This will help SAF-1696

test plan:
see related PR in semgrep

This will help #SAF-1696

test plan:
see related PR in semgrep
@aryx aryx requested review from a team, brandonspark, amchiclet, IagoAbal and nmote and removed request for a team November 6, 2024 09:14
Copy link

github-actions bot commented Nov 6, 2024

Backwards compatibility summary:

Checking backward compatibility of semgrep_output_v1.atd against past version v1.29.0
Skipping v1.30.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.1 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.31.2 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Skipping v1.32.0 because commit 78720c795cd5a186f5102c87125ef876c6435a0c has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.33.0
Skipping v1.33.1 because commit 8849e56ddb0977e38a120a6cfbd1c396eb6fa15e has already been checked
Skipping v1.33.2 because commit 8849e56ddb0977e38a120a6cfbd1c396eb6fa15e has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.34.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.37.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.38.0
Skipping v1.38.1 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Skipping v1.38.2 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Skipping v1.38.3 because commit fd294683e7369cabf63738febeaba8a22c925187 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.39.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.40.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.41.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.42.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.43.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.44.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.45.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.46.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.47.0
Skipping v1.48.0 because commit 278ed753e0c66b8bfc3f2d805fde53be022dd4b6 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.49.0
Skipping v1.50.0 because commit 857682f41eb09e0b330a247ff1adf3bfeaf9d9ca has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.52.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.53.0
Skipping v1.54.0 because commit 3b72d494260258497e796d094b1a4916501a6df1 has already been checked
Skipping v1.54.1 because commit 3b72d494260258497e796d094b1a4916501a6df1 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.54.2
Skipping v1.54.3 because commit 9f1c50383a9a9969e2fe7a5f9bff9ca0a7c837bb has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.55.0
Skipping v1.55.1 because commit 6dffeaa692153fd33b4f154fddaefde1f2f1ae27 has already been checked
Skipping v1.55.2 because commit 6dffeaa692153fd33b4f154fddaefde1f2f1ae27 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.56.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.57.0
Skipping v1.58.0 because commit 4cc11b00d411c02fc611aa8c78a336520438fb48 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.59.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.59.1
Checking backward compatibility of semgrep_output_v1.atd against past version v1.60.0
Skipping v1.60.1 because commit eed58a091fd7d19e402a6d4cf2d287e137215d03 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.61.0
Skipping v1.61.1 because commit bbfd1c5b91bd411bceffc3de73f5f0b37f04433d has already been checked
Skipping v1.62.0 because commit bbfd1c5b91bd411bceffc3de73f5f0b37f04433d has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.63.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.64.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.65.0
Skipping v1.66.0 because commit 3e7bbafa2b7e722d893303a7fb90a83dab6737a7 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.66.1
Skipping v1.66.2 because commit 215a54782174de84f97188632b4a37e35ba0f827 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.67.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.68.0
Skipping v1.69.0 because commit d5b91fa4f6a03240db31e9bbbc5376a99bc8eeea has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.70.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.71.0
Skipping v1.72.0 because commit 75abf193687b84ab341d8267d865ad68d81a89c9 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.73.0
Skipping v1.74.0 because commit 9f38254957c50c68ea402eebae0f7aa40dd01cbf has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.75.0
Skipping v1.76.0 because commit 9102031608aa4154e1c37f557550ec4eabc8780c has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.77.0
Skipping v1.78.0 because commit dcb5d77b420ddee61f58aadd3c2c7aef38778154 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.79.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.80.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.81.0
Skipping v1.82.0 because commit 9e0f3bec26b07b4fb6753a32cb75277f45f2572c has already been checked
Skipping v1.83.0 because commit 9e0f3bec26b07b4fb6753a32cb75277f45f2572c has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.84.0
--- before.txt
+++ after.txt
@@ -1,3 +1,8 @@
+[346efceb] Incompatibility in both directions:
+Incompatible tuple lengths
+The following types are affected:
+  function_call
+
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
 The following types are affected:
ERROR: semgrep_output_v1.atd is not backward compatible with v1.84.0
Skipping v1.84.1 because commit 3daef49297ada205359cc1d2996354c94b628b0d has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.85.0
--- before.txt
+++ after.txt
@@ -1,3 +1,8 @@
+[346efceb] Incompatibility in both directions:
+Incompatible tuple lengths
+The following types are affected:
+  function_call
+
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
 The following types are affected:
ERROR: semgrep_output_v1.atd is not backward compatible with v1.85.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.86.0
--- before.txt
+++ after.txt
@@ -1,3 +1,8 @@
+[346efceb] Incompatibility in both directions:
+Incompatible tuple lengths
+The following types are affected:
+  function_call
+
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
 The following types are affected:
ERROR: semgrep_output_v1.atd is not backward compatible with v1.86.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.87.0
--- before.txt
+++ after.txt
@@ -1,3 +1,8 @@
+[346efceb] Incompatibility in both directions:
+Incompatible tuple lengths
+The following types are affected:
+  function_call
+
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
 The following types are affected:
ERROR: semgrep_output_v1.atd is not backward compatible with v1.87.0
Skipping v1.88.0 because commit 512c0bd97db59c48a5705b2741662a338776e438 has already been checked
Skipping v1.89.0 because commit 512c0bd97db59c48a5705b2741662a338776e438 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.90.0
--- before.txt
+++ after.txt
@@ -1,3 +1,8 @@
+[346efceb] Incompatibility in both directions:
+Incompatible tuple lengths
+The following types are affected:
+  function_call
+
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
 The following types are affected:
ERROR: semgrep_output_v1.atd is not backward compatible with v1.90.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.91.0
--- before.txt
+++ after.txt
@@ -1,3 +1,8 @@
+[346efceb] Incompatibility in both directions:
+Incompatible tuple lengths
+The following types are affected:
+  function_call
+
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
 The following types are affected:
ERROR: semgrep_output_v1.atd is not backward compatible with v1.91.0
Skipping v1.92.0 because commit 2351c5e528cb7430422208dc66707894c066b508 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.93.0
--- before.txt
+++ after.txt
@@ -1,3 +1,8 @@
+[346efceb] Incompatibility in both directions:
+Incompatible tuple lengths
+The following types are affected:
+  function_call
+
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
 The following types are affected:
ERROR: semgrep_output_v1.atd is not backward compatible with v1.93.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.94.0
--- before.txt
+++ after.txt
@@ -0,0 +1,5 @@
+[346efceb] Incompatibility in both directions:
+Incompatible tuple lengths
+The following types are affected:
+  function_call
+
ERROR: semgrep_output_v1.atd is not backward compatible with v1.94.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.95.0
--- before.txt
+++ after.txt
@@ -0,0 +1,5 @@
+[346efceb] Incompatibility in both directions:
+Incompatible tuple lengths
+The following types are affected:
+  function_call
+
ERROR: semgrep_output_v1.atd is not backward compatible with v1.95.0

@aryx
Copy link
Collaborator Author

aryx commented Nov 6, 2024

the error concerns function_call which is part of the RPC framework which does not have to be backward compatible so we're fine.

Copy link
Contributor

@IagoAbal IagoAbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IagoAbal
Copy link
Contributor

IagoAbal commented Nov 6, 2024

the error concerns function_call which is part of the RPC framework which does not have to be backward compatible so we're fine.

It would be nice to add function_call to a whitelist or something.

@aryx
Copy link
Collaborator Author

aryx commented Nov 6, 2024

@mjambon can we customize the backward compatiblity check and do the whitelisting iago proposed?

@aryx aryx merged commit 1446208 into main Nov 6, 2024
2 of 3 checks passed
@aryx aryx deleted the format_context branch November 6, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants