-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format_context and complete output_format for RPC call to format #310
Conversation
This will help #SAF-1696 test plan: see related PR in semgrep
Backwards compatibility summary:
|
the error concerns function_call which is part of the RPC framework which does not have to be backward compatible so we're fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It would be nice to add |
@mjambon can we customize the backward compatiblity check and do the whitelisting iago proposed? |
This will help SAF-1696
test plan:
see related PR in semgrep
make setup && make
to update the generated code after editing a.atd
file (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data generated
by Semgrep 1.17.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades