-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sca): new SCA stats schema #313
Merged
salolivares
merged 17 commits into
main
from
sal/sc-1956-update-semgrep-interfaces-with-new-stats-schema
Nov 19, 2024
Merged
feat(sca): new SCA stats schema #313
salolivares
merged 17 commits into
main
from
sal/sc-1956-update-semgrep-interfaces-with-new-stats-schema
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backwards compatibility summary:
|
salolivares
commented
Nov 12, 2024
salolivares
commented
Nov 12, 2024
bkettle
reviewed
Nov 12, 2024
salolivares
commented
Nov 12, 2024
aryx
requested changes
Nov 14, 2024
aryx
requested changes
Nov 14, 2024
chmccreery
reviewed
Nov 19, 2024
chmccreery
reviewed
Nov 19, 2024
chmccreery
reviewed
Nov 19, 2024
aryx
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bkettle
reviewed
Nov 19, 2024
bkettle
reviewed
Nov 19, 2024
bkettle
approved these changes
Nov 19, 2024
chmccreery
approved these changes
Nov 19, 2024
salolivares
deleted the
sal/sc-1956-update-semgrep-interfaces-with-new-stats-schema
branch
November 19, 2024 22:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The existing "bytes parsed" metric we are currently relying on provides a limited perspective on customer SSC adoption, as it aggregates usage across languages without fully capturing which languages are meaningfully used.
We want to augment the stats schema to improve metrics around Java dependency detection, lockfile-less scanning, and python requirements identification.
make setup && make
to update the generated code after editing a.atd
file (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data generated
by Semgrep 1.17.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades