Rename type xlang -> analyzer #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjambon
force-pushed
the
martin/rename-xlang
branch
from
f8c31fc to
0f605c8
Compare
|
Backwards compatibility summary: |
aryx
approved these changes
Jan 9, 2025
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Jan 13, 2025
Requires semgrep/semgrep-interfaces#331 where the OCaml module name is referenced (`Xlang` is now `Analyzer`). After this, I'll see if I can simplify the type definition to turn `| L of Lang.t * Lang.t list` into `L of Lang.t`. synced from Pro 7f018c03889d83fd84af6e3fa929ffa5d1865931
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Jan 14, 2025
Requires semgrep/semgrep-interfaces#331 where the OCaml module name is referenced (`Xlang` is now `Analyzer`). After this, I'll see if I can simplify the type definition to turn `| L of Lang.t * Lang.t list` into `L of Lang.t`. synced from Pro 7f018c03889d83fd84af6e3fa929ffa5d1865931
nmote
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Jan 14, 2025
Requires semgrep/semgrep-interfaces#331 where the OCaml module name is referenced (`Xlang` is now `Analyzer`). After this, I'll see if I can simplify the type definition to turn `| L of Lang.t * Lang.t list` into `L of Lang.t`. synced from Pro 7f018c03889d83fd84af6e3fa929ffa5d1865931
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of renaming the OCaml module
XlangtoAnalyzer. This type name change doesn't change the data format because type names don't occur in JSON data.make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!