cleanup semgrep ci config section #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test plan: make
aryx
requested review from
a team,
emjin,
mjambon,
ajbt200128 and
chmccreery
and removed request for
a team and
emjin
|
Backwards compatibility summary: |
mjambon
reviewed
Jan 10, 2025
| type product_ignored_files = (product * glob list) list | ||
| (* We omit the usual <json repr="object"> otherwise we get a | ||
| * "keys must be strings" error *) | ||
| <python repr="dict"> <ts repr="map"> |
There was a problem hiding this comment.
We should avoid tuples in favor of records if possible. This allows future extensions, optional fields, easier debugging when working on JSON data, etc.:
type product_ignored_files = {
product: product;
ignored_files: glob list;
}
type ignored_files = product_ignored_files list
or maybe something like this:
type product_ignored_files = {
~sast: glob list;
~sca: glob list;
~secrets: glob list;
}
There was a problem hiding this comment.
oh nevermind, it's old code that just moved.
mjambon
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test plan:
make
make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!