simplify the RPC for SARIF

[aryx]

The goal is to make it as close as possible as the general
CallFormat so at some point we can merge them.

test plan:
see related PR in semgrep

• I ran make setup && make to update the generated code after editing a .atd file (TODO: have a CI check)
• I made sure we're still backward compatible with old versions of the CLI.
  For example, the Semgrep backend need to still be able to consume data
  generated by Semgrep 1.50.0.
  See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
  Note that the types related to the semgrep-core JSON output or the
  semgrep-core RPC do not need to be backward compatible!

[github-actions]

Backwards compatibility summary:

Checking backward compatibility of semgrep_output_v1.atd against past version v1.100.0
--- before.txt
+++ after.txt
@@ -0,0 +1,16 @@
+[24d097fd] Possible backward incompatibility:
+The definition for type 'sarif_format_params' no longer exists.
+The following types are affected:
+  sarif_format_params
+
+[346efceb] Incompatibility in both directions:
+Incompatible tuple lengths
+The following types are affected:
+  function_call
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
+
ERROR: semgrep_output_v1.atd is not backward compatible with v1.100.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.101.0
--- before.txt
+++ after.txt
@@ -0,0 +1,16 @@
+[24d097fd] Possible backward incompatibility:
+The definition for type 'sarif_format_params' no longer exists.
+The following types are affected:
+  sarif_format_params
+
+[346efceb] Incompatibility in both directions:
+Incompatible tuple lengths
+The following types are affected:
+  function_call
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
+
ERROR: semgrep_output_v1.atd is not backward compatible with v1.101.0
Skipping v1.102.0 because commit 1c82453e89e0b569630e48ddde015e201df0e5f9 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.49.0
Skipping v1.50.0 because commit 857682f41eb09e0b330a247ff1adf3bfeaf9d9ca has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.52.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.53.0
Skipping v1.54.0 because commit 3b72d494260258497e796d094b1a4916501a6df1 has already been checked
Skipping v1.54.1 because commit 3b72d494260258497e796d094b1a4916501a6df1 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.54.2
Skipping v1.54.3 because commit 9f1c50383a9a9969e2fe7a5f9bff9ca0a7c837bb has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.55.0
Skipping v1.55.1 because commit 6dffeaa692153fd33b4f154fddaefde1f2f1ae27 has already been checked
Skipping v1.55.2 because commit 6dffeaa692153fd33b4f154fddaefde1f2f1ae27 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.56.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.57.0
Skipping v1.58.0 because commit 4cc11b00d411c02fc611aa8c78a336520438fb48 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.59.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.59.1
Checking backward compatibility of semgrep_output_v1.atd against past version v1.60.0
Skipping v1.60.1 because commit eed58a091fd7d19e402a6d4cf2d287e137215d03 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.61.0
Skipping v1.61.1 because commit bbfd1c5b91bd411bceffc3de73f5f0b37f04433d has already been checked
Skipping v1.62.0 because commit bbfd1c5b91bd411bceffc3de73f5f0b37f04433d has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.63.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.64.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.65.0
Skipping v1.66.0 because commit 3e7bbafa2b7e722d893303a7fb90a83dab6737a7 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.66.1
Skipping v1.66.2 because commit 215a54782174de84f97188632b4a37e35ba0f827 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.67.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.68.0
Skipping v1.69.0 because commit d5b91fa4f6a03240db31e9bbbc5376a99bc8eeea has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.70.0
--- before.txt
+++ after.txt
@@ -4,11 +4,6 @@
   function_call
   sarif_format_params
 
-[2536f296] Backward incompatibility:
-Required field 'show_dataflow_traces' is new.
-The following types are affected:
-  sarif_format_params
-
 [2ed4093f] Incompatibility in both directions:
 Incompatible kinds of types: int is now a record/object.
 The following types are affected:
@@ -25,6 +20,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.70.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.71.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -25,6 +20,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.71.0
Skipping v1.72.0 because commit 75abf193687b84ab341d8267d865ad68d81a89c9 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.73.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -25,6 +20,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.73.0
Skipping v1.74.0 because commit 9f38254957c50c68ea402eebae0f7aa40dd01cbf has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.75.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -25,6 +20,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.75.0
Skipping v1.76.0 because commit 9102031608aa4154e1c37f557550ec4eabc8780c has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.77.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -25,6 +20,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.77.0
Skipping v1.78.0 because commit dcb5d77b420ddee61f58aadd3c2c7aef38778154 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.79.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -25,6 +20,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.79.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.80.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -18,6 +13,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.80.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.81.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -18,6 +13,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.81.0
Skipping v1.82.0 because commit 9e0f3bec26b07b4fb6753a32cb75277f45f2572c has already been checked
Skipping v1.83.0 because commit 9e0f3bec26b07b4fb6753a32cb75277f45f2572c has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.84.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -23,6 +18,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.84.0
Skipping v1.84.1 because commit 3daef49297ada205359cc1d2996354c94b628b0d has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.85.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -23,6 +18,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.85.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.86.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -23,6 +18,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.86.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.87.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -23,6 +18,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [3cb750d6] Backward incompatibility:
 Formerly optional field 'version' is now required.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.87.0
Skipping v1.88.0 because commit 512c0bd97db59c48a5705b2741662a338776e438 has already been checked
Skipping v1.89.0 because commit 512c0bd97db59c48a5705b2741662a338776e438 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.90.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -37,6 +32,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [385fcd66] Incompatibility in both directions:
 Incompatible kinds of types: sum type or enum is now a list/array.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.90.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.91.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -37,6 +32,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [385fcd66] Incompatibility in both directions:
 Incompatible kinds of types: sum type or enum is now a list/array.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.91.0
Skipping v1.92.0 because commit 2351c5e528cb7430422208dc66707894c066b508 has already been checked
Checking backward compatibility of semgrep_output_v1.atd against past version v1.93.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -37,6 +32,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [385fcd66] Incompatibility in both directions:
 Incompatible kinds of types: sum type or enum is now a list/array.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.93.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.94.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -37,6 +32,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [385fcd66] Incompatibility in both directions:
 Incompatible kinds of types: sum type or enum is now a list/array.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.94.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.95.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -37,6 +32,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [385fcd66] Incompatibility in both directions:
 Incompatible kinds of types: sum type or enum is now a list/array.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.95.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.96.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -32,6 +27,12 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
 [385fcd66] Incompatibility in both directions:
 Incompatible kinds of types: sum type or enum is now a list/array.
ERROR: semgrep_output_v1.atd is not backward compatible with v1.96.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.97.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -18,4 +13,10 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
ERROR: semgrep_output_v1.atd is not backward compatible with v1.97.0
Checking backward compatibility of semgrep_output_v1.atd against past version v1.98.0
--- before.txt
+++ after.txt
@@ -1,8 +1,3 @@
-[02d661c1] Backward incompatibility:
-Formerly optional field 'show_dataflow_traces' is now required.
-The following types are affected:
-  sarif_format_params
-
 [0cc0ff7d] Incompatibility in both directions:
 Incompatible kinds of types: record/object is now a tuple.
 The following types are affected:
@@ -18,4 +13,10 @@
 Formerly optional field 'project_metadata' is now required.
 The following types are affected:
   scan_request
+
+[37910eb5] Incompatibility in both directions:
+Incompatible kinds of types: record/object is now a string.
+The following types are affected:
+  function_return
+  sarif_format_return
 
ERROR: semgrep_output_v1.atd is not backward compatible with v1.98.0
Skipping v1.99.0 because commit 60809032a2e39742f42910d46b3e5dd305b8b8cf has already been checked

[aryx]

The lint checks are failure are normal. We do not care about backward compatibility for RPCs types.