Update README with new Minimum Config File and Clarification.#156
Open
jkinsfather wants to merge 12 commits intodevelopfrom
Open
Update README with new Minimum Config File and Clarification.#156jkinsfather wants to merge 12 commits intodevelopfrom
jkinsfather wants to merge 12 commits intodevelopfrom
Conversation
Removing reference to JIRA on-prem since it is not yet supported. Signed-off-by: jk <139381146+jkinsfather@users.noreply.github.com>
Signed-off-by: jk <139381146+jkinsfather@users.noreply.github.com>
Contributor
|
@jkinsfather fantastic improvement to the readme. Thank you so much. A couple of small suggestions from me but nothing big. Looks great! |
Co-authored-by: semgrep-jamie <jamie@semgrep.com> Signed-off-by: jk <139381146+jkinsfather@users.noreply.github.com>
Co-authored-by: semgrep-jamie <jamie@semgrep.com> Signed-off-by: jk <139381146+jkinsfather@users.noreply.github.com>
Co-authored-by: semgrep-jamie <jamie@semgrep.com> Signed-off-by: jk <139381146+jkinsfather@users.noreply.github.com>
Contributor
|
Vivek & Matthew - if you could review the related & complementary #155 around the same time, your inputs would be valued! |
Contributor
|
@jkinsfather -- Thinking on this more, would it be more maintainable to move your excellent documentation to https://semgrep.dev/docs/semgrep-ci/network-broker and trim this README down to only contribution instructions? One of the painpoints in broker setup right now is that there are multiple sources of truth which i believe confuses everyone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a massive overhaul of the README.
The goals are: