Introduce SEMGREP_NETWORK_BROKER_PRIVATE_KEY env variable#170
Open
semgrep-jamie wants to merge 1 commit intodevelopfrom
Open
Introduce SEMGREP_NETWORK_BROKER_PRIVATE_KEY env variable#170semgrep-jamie wants to merge 1 commit intodevelopfrom
semgrep-jamie wants to merge 1 commit intodevelopfrom
Conversation
…ble, rather than in config file.
semgrep-jamie
force-pushed
the
jr/add-SEMGREP_NETWORK_BROKER_PRIVATE_KEY-env-var
branch
from
e25d28a to
9feeb01
Compare
semgrep-jamie
requested review from
chmccreery,
kpurdon and
matthewdean-semgrep
as code owners
Contributor
Author
|
Since I'll be testing #199 in a lab environment before opening a PR to cut a new release, I figured it was an opportune time to revisit this old PR that I'd raised based on a prospect's suggestion. I do think that providing an env variable is a nice quality of life improvement that could improve the security of secrets handling for many deployment environments. I'll test this alongside #199 when I get a chance in a few weeks. In the interim, would love a review and any comments from those tagged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for the configuration of the wireguard privateKey as an environment variable,
$SEMGREP_NETWORK_BROKER_PRIVATE_KEYinstead of within the config yaml.