Add subprocess-list-passed-as-string for Python #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subprocess.run and similar takes either a string or a sequence. Some calling code has a sequence, but converts it to string themselves. This is both unnecessary and insecure, as it removes the distinction between arguments. I.e. if arguments contain spaces or quotes this gives the wrong result.
…thon/lang/security/audit/subprocess-list-passed-as-string.py
…python/lang/security/audit/subprocess-list-passed-as-string.yaml
inkz
approved these changes
Mar 25, 2025
inkz
added a commit
that referenced
this pull request
Mar 26, 2025
* Improve `insecure-load-balancer-tls-version` AWS rule (#3584) Add support for `ELBSecurityPolicy-TLS13-1-2-Res-2021-06`, which is the most secure TLS 1.2+ policy that AWS ALBs offer. Recommend it as the preferred fix for rule failures. `ELBSecurityPolicy-TLS13-1-2-Res-2021-06` removes the following (insecure) cipher suites as compared to `ELBSecurityPolicy-TLS13-1-2-2021-06` because they are CBC-based instead of GCM-based: - ECDHE-ECDSA-AES128-SHA256 - ECDHE-RSA-AES128-SHA256 - ECDHE-ECDSA-AES256-SHA384 - ECDHE-RSA-AES256-SHA384 https://docs.aws.amazon.com/elasticloadbalancing/latest/application/describe-ssl-policies.html#tls-security-policies Also, improve/clean-up related test. Co-authored-by: Vasilii Ermilov <[email protected]> * Add subprocess-list-passed-as-string for Python (#3579) * Add subprocess-list-passed-as-string for Python subprocess.run and similar takes either a string or a sequence. Some calling code has a sequence, but converts it to string themselves. This is both unnecessary and insecure, as it removes the distinction between arguments. I.e. if arguments contain spaces or quotes this gives the wrong result. * Update subprocess-list-passed-as-string.yaml * Rename python/lang/security/subprocess-list-passed-as-string.py to python/lang/security/audit/subprocess-list-passed-as-string.py * Rename python/lang/security/subprocess-list-passed-as-string.yaml to python/lang/security/audit/subprocess-list-passed-as-string.yaml --------- Co-authored-by: Vasilii Ermilov <[email protected]> Co-authored-by: Vasilii Ermilov <[email protected]> * bump Ubuntu version in Github actions (#3593) * bump Ubuntu version in Github actions * bump setup-python version * bump python versions in Github actions * bump python versions in Github actions --------- Co-authored-by: Reed Loden <[email protected]> Co-authored-by: Vasilii Ermilov <[email protected]> Co-authored-by: Sjoerd Langkemper <[email protected]> Co-authored-by: Vasilii Ermilov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subprocess.run and similar takes either a string or a sequence. Some calling code has a sequence, but converts it to string themselves. This is both unnecessary and insecure, as it removes the distinction between arguments. I.e. if arguments contain spaces or quotes this gives the wrong result.