Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade upload/download-artifact GitHub actions to v4 #197

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

apt-itude
Copy link
Contributor

Related to https://linear.app/semgrep/issue/INFRA-3279/upgrade-actionsupload-artifact-and-actionsdownload-artifact-to-v4

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

@apt-itude apt-itude requested review from ajbt200128 and a team January 28, 2025 16:10
Copy link

@spencerdrak spencerdrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM for the change you made, but the other warnings might need to be fixed

@ajbt200128
Copy link
Contributor

yea @apt-itude do you mind bumping the other action versions? I'll look into the other test failures but it looks like they're the same as what's failing on main so you should be fine to ignore them

@ajbt200128 ajbt200128 merged commit 344b4f0 into develop Jan 29, 2025
8 of 10 checks passed
@ajbt200128 ajbt200128 deleted the at/gha-artifact-actions-upgrade branch January 29, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants