Update review-ready changes#22
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (20)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 59 minutes and 52 seconds.Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e46206b45
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | App module | `src/modules/{Module}/Application/Command/{Name}Command.php` | `Semitexa\Modules\{Module}\Application\Command` | | ||
| | Package | `packages/semitexa-{pkg}/src/Console/Command/{Name}Command.php` | `Semitexa\{Pkg}\Console\Command` | |
There was a problem hiding this comment.
The new “Console command placement” table documents src/modules/{Module}/Application/Command/... and packages/semitexa-{pkg}/src/Console/Command/..., but the canonical spec in docs/MODULE_STRUCTURE.md requires Application/Console/Command/ for both app modules and packages (see its rules around module_structure.command_wrong_location). Following this new guidance will cause contributors to place commands in paths that fail ai:verify/structure checks and contradict the command move done in this same commit.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 645b165843
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| Package root may contain package metadata/config files such as `LICENSE`, `README.md`, `CHANGELOG.md`, `phpunit.xml`, `phpunit.xml.dist`, `phpstan.neon`, `.gitignore`, Docker/install files, and package tooling directories such as `tests/`, `docs/`, `bin/`, `resources/`, `tools/`, `public/`, `.github/`, and `var/`. | ||
|
|
||
| Package `src/` follows the **same strict allowlist** as an application module's root. The only top-level directories permitted at `packages/semitexa-{name}/src/` are the canonical layers from § 2 (`Application`, `Domain`, `Context`, `Configuration`, `Update`, `Static`, `View`) plus `Attributes/` (package-only). There is no special "package source is package-specific" exemption — historical drift such as `Auth/`, `Discovery/`, `OpenApi/`, `Pipeline/`, `Transport/` at the package source root is rejected with `module_structure.unknown_directory`. Move such code into the appropriate canonical sub-tree (typically `Application/Service/`, `Domain/Service/`, or `Domain/Contract/`). |
There was a problem hiding this comment.
This line declares Update, Static, and View as top-level directories under packages/semitexa-{name}/src/, but the same spec’s canonical tree in §2 places them under Application/ (e.g., Application/Update, Application/Static, Application/View). Because this file is marked authoritative for ai:verify, the contradiction will mislead contributors into placing files in paths that violate the validator depending on which section they follow.
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
Summary
developtargetingmaster3commit(s) ahead,10changed file(s)Changes
Checks
What to Review
docs/AI_BEST_PRACTICES.mddocs/MODULE_STRUCTURE.mddocs/endocs/workspacesrc/Applicationtests/IntegrationWhat to Verify