Backfill PR numbers on the top 2.0.0 changelog entries#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
The 2.0.0 section of
CHANGES.mdhad a run of recent entries without a leading PR number, breaking the#NN <title>convention the rest of the file uses. Three of them also had wording that had drifted from the actual PR title.Current behavior before PR
Top of 2.0.0 reads as a mix of
#NN-prefixed and bare entries; readers cannot click through to the PR for the recent items.Desired behavior after PR is merged
Every 2.0.0 entry is prefixed by its PR number. Where the entry text disagreed with the PR title (#73, #74, #75), the text is replaced with the verbatim PR title so the changelog stays linkable.
Test
Docs-only change.