Skip to content

Fix local detection of Dexterity @@images resources in Impress url_fetcher #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lunga001 wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Fix local detection of Dexterity @@images resources in Impress url_fetcher #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions src/senaite/impress/publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,12 @@ def _layout_and_paginate(self, html):

@synchronized(max_connections=2)
def url_fetcher(self, url):
"""Fetches internal URLs by path and not via an external request.
"""Fetch internal URLs by path instead of via an external request.

Browser views such as ``@@images`` handle parts of their paths
dynamically. Therefore, the owning content object is used when checking
whether an image resource is local, while the complete path is passed to
the authenticated subrequest.

N.B. Multiple calls to this method might exhaust the available threads
of the server, which causes a hanging instance.
Expand All @@ -156,37 +161,44 @@ def url_fetcher(self, url):

logger.info("Fetching URL '{}' for WeasyPrint".format(url))

# get the pyhsical path from the URL
request = api.get_request()
portal = api.get_portal()

host = request.get_header("HOST")
path = "/".join(request.physicalPathFromURL(url))

# fetch the object by sub-request
portal = api.get_portal()
context = portal.restrictedTraverse(path, None)
# The final field segment after @@images is handled dynamically by the
# images browser view and might not resolve with restrictedTraverse.
traverse_path = path
if "/@@images/" in path:
traverse_path = path.split("/@@images/", 1)[0]

context = portal.restrictedTraverse(traverse_path, None)

if context is None or (host and host not in url):
logger.info("External URL, delegate to default URL fetcher...")
return default_url_fetcher(url)

logger.info("Local URL, fetching data by path '{}'".format(path))

# get the data via an authenticated subrequest
# Fetch the local resource through an authenticated Zope subrequest.
response = subrequest(path)

# Prepare the return data as required by WeasyPrint
string = response.getBody()
filename = url.split("/")[-1]
mime_type = mimetypes.guess_type(url)[0]
redirected_url = url
filename = url.rstrip("/").split("/")[-1]

# Dynamic URLs such as @@images/accreditation_body_logo have no file
# extension, so prefer the response's actual Content-Type.
mime_type = response.getHeader("Content-Type")
if not mime_type:
mime_type = mimetypes.guess_type(url)[0]

return {
"string": string,
"filename": filename,
"mime_type": mime_type,
"redirected_url": redirected_url,
"redirected_url": url,
}

def write_png(self, html, resolution=96):
"""Write a PNG from the given HTML
"""
Expand Down