-
Notifications
You must be signed in to change notification settings - Fork 142
[chore]: auto-approve release PRs via automation #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| name: Approve by automation | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize] | ||
|
|
||
| permissions: | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| approve-release-pr: | ||
| if: startsWith(github.head_ref, 'release/v') | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Approve release pull request | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh pr review "${{ github.event.pull_request.number }}" \ | ||
| --approve \ | ||
| --body "Auto-approved: release branch PR. Release is gated by the Jira EM approval." \ | ||
| --repo "${{ github.repository }}" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a same-repository PR whose source branch merely starts with
release/v, this job submits an approving review without checking the base branch, actor, or the semver release-branch pattern used by.github/workflows/release-workflow.yml(^release/v[0-9]+\.[0-9]+\.[0-9]+$). That lets any write-access user create something likerelease/v-anythingtargetingmainand have the one required GitHub approval satisfied by automation, bypassing the human review gate for non-release changes that pass required checks. Please tighten this condition to the exact release branch format and intended target/actor before approving.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.