Added Commitlint and Changelog #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also added Commitizen for easily writing commit messages ISSUES CLOSED: sendilkumarn#10
Symphoria
force-pushed
the
enhance/commitlint
branch
from
f01b846 to
3509028
Compare
dhruvdutt
suggested changes
Mar 10, 2018
CHANGELOG.md
Outdated
|
|
||
| ## New Features | ||
|
|
||
| * add circle ci batch ([626fa2f](https://github.com/Symphoria/webpack-addons-pwa/commit/626fa2f)) |
There was a problem hiding this comment.
Can you change the repo to point upstream sendilkumarn/webpack-addons-pw?
|
@sendilkumarn @dhruvdutt Made the changes. Please review |
dhruvdutt
suggested changes
Mar 10, 2018
.cz-config.js
Outdated
| scopes: [], | ||
| types: [ | ||
| { value: "feat", name: "feat: A new feature" }, | ||
| { value: "tests", name: "tests: Tests, jest, binTestCases, etc" }, |
There was a problem hiding this comment.
We don't use jest. Also, you can clear binTestCases.
.cz-config.js
Outdated
| { value: "tests", name: "tests: Tests, jest, binTestCases, etc" }, | ||
| { value: "docs", name: "docs: Documentation" }, | ||
| { value: "misc", name: "misc: Other formats like tweaks and such" }, | ||
| { value: "chore", name: "chore: Updating docs, linting, grunt tasks etc" }, |
dhruvdutt
approved these changes
Mar 10, 2018
sendilkumarn
requested changes
Mar 11, 2018
| @@ -0,0 +1 @@ | |||
| build | |||
There was a problem hiding this comment.
add one more blank line here
| @@ -0,0 +1,86 @@ | |||
| <a name="1.0.0"></a> | |||
| # 1.0.0 (2018-03-10) | |||
There was a problem hiding this comment.
Actually, 1.0.0 is the version specified in package.json. Do I increase the version in package.json? @sendilkumarn
| process.stderr.write(` | ||
| > Be sure to have the latest git tags locally: | ||
| git fetch --tags | ||
|
|
|
@Symphoria did you plan to work on this ? |
|
@Symphoria @sendilkumarn there are few minor changes left in this PR, would be nice if this PR is resolved!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.