Skip to content

Fix test_undefined_slot_raises: only swallow missing-parent-class errors #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sulstice merged 1 commit into from
Jul 24, 2026
+7 −3
Merged

Fix test_undefined_slot_raises: only swallow missing-parent-class errors #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions neuro_ghost/ingest_linkml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,13 @@ def parse_linkml(path: Path) -> dict[str, Any]:

try:
induced_slots = sv.class_induced_slots(cls_name)
except (ValueError, KeyError):
# is_a points to a class outside this schema (e.g. NWB's "Container")
# Fall back to directly-declared slots only.
except (ValueError, KeyError) as exc:
msg = str(exc)
# Only tolerate "No such class" — that means is_a points outside
# this schema (e.g. NWB's NWBContainer → Container). A missing
# slot is a genuine schema error; re-raise so the caller sees it.
if "No such class" not in msg:
raise
induced_slots = list(cls_def.attributes.values())
for sname in (cls_def.slots or []):
try:
Expand Down
Loading