Skip to content

fix(stage6): canonical NeuroScape URLs + mirror link-check to PR preview #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satra merged 1 commit into from
May 17, 2026
Merged

fix(stage6): canonical NeuroScape URLs + mirror link-check to PR preview #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/deploy-ui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ on:
paths:
- 'site/**'
- '.github/workflows/deploy-ui.yml'
- 'specs/008-ui-rewrite/contracts/references.yaml'
- 'src/ohbm2026/ui_data/link_check.py'
workflow_dispatch:

permissions:
Expand Down
16 changes: 16 additions & 0 deletions .github/workflows/pr-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ on:
paths:
- 'site/**'
- '.github/workflows/pr-preview.yml'
- 'specs/008-ui-rewrite/contracts/references.yaml'
- 'src/ohbm2026/ui_data/link_check.py'
workflow_dispatch:

permissions:
Expand Down Expand Up @@ -46,6 +48,20 @@ jobs:
working-directory: site
run: pnpm test:unit --run

- name: Set up Python 3.14
uses: actions/setup-python@v5
with:
python-version: '3.14'

- name: Install link-check deps
run: pip install requests pyyaml

- name: References link check (FR-017)
# Same check that gates the production deploy in deploy-ui.yml —
# mirrored here so PR previews surface a broken reference BEFORE
# the merge instead of failing at deploy time.
run: PYTHONPATH=src python -m ohbm2026.ui_data.link_check specs/008-ui-rewrite/contracts/references.yaml

- name: Build site (PR preview)
working-directory: site
env:
Expand Down
8 changes: 4 additions & 4 deletions site/src/routes/about/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@
url: 'https://openalex.org/'
},
neuroscape_repo: {
title: 'NeuroScape — code repository',
url: 'https://github.com/sensein/neuroscape'
title: 'NeuroScape — code repository (ccnmaastricht)',
url: 'https://github.com/ccnmaastricht/NeuroScape'
},
neuroscape_paper: {
title:
'Vali Tehrani et al. (2024) — NeuroScape: a domain-specific embedding for neuroscience abstracts (Aperture Neuro)',
url: 'https://apertureneuro.org/article/124574-neuroscape-a-domain-specific-embedding-for-neuroscience-abstracts'
'The evolving landscape of neuroscience — Aperture Neuro',
url: 'https://apertureneuro.org/article/156380-the-evolving-landscape-of-neuroscience'
Comment on lines +47 to +53

@gemini-code-assist gemini-code-assist Bot May 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The titles for the NeuroScape references are inconsistent with the format used for other academic citations in this file (e.g., lines 23, 27, 31, 35), which include the author and year in the string. Additionally, these titles are not synchronized with the corresponding title fields in specs/008-ui-rewrite/contracts/references.yaml. Since these title properties appear to be unused in the Svelte template, they should either be updated for consistency or removed to reduce duplication.

},
repo: {
title: 'OHBM 2026 Atlas — source repository',
Expand Down
12 changes: 6 additions & 6 deletions specs/008-ui-rewrite/contracts/references.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,15 @@ references:
year: 2024
url: https://docs.voyageai.com/docs/embeddings
- section: stage3
title: 'NeuroScape — code repository'
authors: sensein
title: 'NeuroScape — code repository (ccnmaastricht / Cognitive Computational Neuroscience Maastricht)'
authors: ccnmaastricht

@gemini-code-assist gemini-code-assist Bot May 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The authors field uses a GitHub handle (ccnmaastricht) instead of a proper name, which is inconsistent with other entries in this file (e.g., "Oxford Abstracts Ltd.", "Microsoft Research").

    authors: Cognitive Computational Neuroscience Maastricht

year: 2024
url: https://github.com/sensein/neuroscape
url: https://github.com/ccnmaastricht/NeuroScape
- section: stage3
title: 'NeuroScape: a domain-specific embedding for neuroscience abstracts'
authors: Vali Tehrani et al.
title: 'The evolving landscape of neuroscience (Aperture Neuro)'
authors: Cognitive Computational Neuroscience Maastricht et al.

@gemini-code-assist gemini-code-assist Bot May 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using an organization name followed by "et al." is unconventional for scientific paper citations. This field should ideally list the primary human authors of the paper (e.g., "Vali Tehrani et al.") to maintain standard citation practices.

year: 2024
url: https://apertureneuro.org/article/124574-neuroscape-a-domain-specific-embedding-for-neuroscience-abstracts
url: https://apertureneuro.org/article/156380-the-evolving-landscape-of-neuroscience

# ---- Stage 4 — analysis ----
- section: stage4
Expand Down
Loading