Skip to content

286 Task Add 20 Audio Quality Metrics#287

Closed
ibevers wants to merge 72 commits into
mainfrom
286-task-add-20-aqms-independently
Closed

286 Task Add 20 Audio Quality Metrics#287
ibevers wants to merge 72 commits into
mainfrom
286-task-add-20-aqms-independently

Conversation

@ibevers

@ibevers ibevers commented Mar 20, 2025

Copy link
Copy Markdown
Collaborator

Description

Depends on:
#353

Adds 20 AQMs to main that are independent of the Bioacoustic QC feature branch as requested by @satra in Slack. Uses cherry-picked commits from: #279

AQMs:

  • proportion of silence
  • silence at beginning
  • silence at end
  • amplitude headroom
  • spectral grating SNR
  • peak SNR (not sure about implementation)
  • proportion clipped
  • clipping present
  • amplitude modulation depth
  • root mean square energy
  • zero crossing rate
  • signal variance
  • dynamic range
  • mean absolute deviation
  • shannon entropy of amplitude
  • crest factor
  • amplitude skew
  • amplitude kurtosis
  • amplitude IQR
  • phase correlation

Related Issue(s)

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@ibevers ibevers linked an issue Mar 20, 2025 that may be closed by this pull request
20 tasks
@ibevers
ibevers requested a review from satra July 18, 2025 16:41
@ibevers

ibevers commented Jul 18, 2025

Copy link
Copy Markdown
Collaborator Author

@satra I've updated based on your feedback! Thank you for your review!

@ibevers ibevers mentioned this pull request Jul 21, 2025
6 tasks
@ibevers ibevers added enhancement New feature or request release minor Minor release to-test to-test-gpu labels Jul 23, 2025
@codecov-commenter

codecov-commenter commented Jul 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.35294% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.45%. Comparing base (113721a) to head (4015b2e).
⚠️ Report is 1091 commits behind head on main.

Files with missing lines Patch % Lines
src/senselab/audio/tasks/bioacoustic_qc/metrics.py 94.97% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   60.24%   67.45%   +7.21%     
==========================================
  Files         113      142      +29     
  Lines        4017     6536    +2519     
==========================================
+ Hits         2420     4409    +1989     
- Misses       1597     2127     +530     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ibevers ibevers changed the title 286 task add 20 aqms 286 Task Add 20 Audio Quality Metrics Aug 11, 2025
@ibevers ibevers added to-test and removed to-test labels Aug 11, 2025
@fabiocat93 fabiocat93 closed this Oct 28, 2025
@fabiocat93
fabiocat93 deleted the 286-task-add-20-aqms-independently branch October 28, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor Minor release release to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Add 20 AQMs

6 participants