-
Notifications
You must be signed in to change notification settings - Fork 10
Merge alpha: classification docs + top_k fix #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -130,13 +130,12 @@ def _classify_windowed( | |
| if len(batch) >= batch_size: | ||
| results = _classify_whole(batch, model=model, device=device, **kwargs) | ||
| for bp, result in zip(batch_positions, results): | ||
| k = min(top_k, len(result.labels)) if result.labels else 0 | ||
| audio_results.append( | ||
| { | ||
| "start": bp / sr, | ||
| "end": min(bp + win_samples, n_samples) / sr, | ||
| "labels": result.labels[:k], | ||
| "scores": result.scores[:k], | ||
| "labels": result.labels[:top_k], | ||
| "scores": result.scores[:top_k], | ||
| "win_length": win_length, | ||
| "hop_length": hop_length, | ||
| } | ||
|
|
@@ -148,13 +147,12 @@ def _classify_windowed( | |
| if batch: | ||
| results = _classify_whole(batch, model=model, device=device, **kwargs) | ||
| for bp, result in zip(batch_positions, results): | ||
| k = min(top_k, len(result.labels)) if result.labels else 0 | ||
| audio_results.append( | ||
| { | ||
| "start": bp / sr, | ||
| "end": min(bp + win_samples, n_samples) / sr, | ||
| "labels": result.labels[:k], | ||
| "scores": result.scores[:k], | ||
| "labels": result.labels[:top_k], | ||
| "scores": result.scores[:top_k], | ||
| "win_length": win_length, | ||
| "hop_length": hop_length, | ||
| } | ||
|
Comment on lines
150
to
158
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
top_kparameter is used here for slicing the results, but it is not passed to the_classify_wholecall on line 131 (and line 148). This means the underlying classifier will use its defaulttop_kvalue (typically 5). If a user requests atop_kvalue larger than the model's default, they will still only receive the default number of labels. Consider passingtop_k=top_kto_classify_wholeto ensure the requested number of labels is retrieved from the model. Additionally, the default value of 5 for windowed mode (set inclassify_audios) contradicts the docstring which states thatNoneshould keep all labels.