Skip to content

Update test parameterization for task_type #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tekrajchhetri merged 1 commit into from
Apr 9, 2026
Merged

Update test parameterization for task_type #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tests/task_detection_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def make_flow(agent_config=None, task_config=None):
)


@pytest.mark.parametrize("task_type", ["ner", "extraction", "keyphrase_extraction"])
@pytest.mark.parametrize("task_type", ["ner", "extraction"])

@gemini-code-assist gemini-code-assist Bot Apr 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The keyphrase_extraction task type is still defined in src/utils/task_detection.py (e.g., in DEFAULT_TAXONOMY and TOOLS_BY_TASK_TYPE). Removing it from this test's parameterization reduces test coverage for a supported task type, which could lead to undetected regressions if its handling changes. It should be included to ensure proper functionality.

Suggested change
@pytest.mark.parametrize("task_type", ["ner", "extraction"])
@pytest.mark.parametrize("task_type", ["ner", "extraction", "keyphrase_extraction"])

def test_task_type_from_config(task_type):
"""task_type is explicitly set in agent_config — returned directly without LLM or heuristic."""
task_config = {
Expand Down
Loading