Skip to content

Update codespell skip list in pre-commit config#111

Merged
tekrajchhetri merged 2 commits into
fix_json_op_issuefrom
tekrajchhetri-fix-test
Apr 9, 2026
Merged

Update codespell skip list in pre-commit config#111
tekrajchhetri merged 2 commits into
fix_json_op_issuefrom
tekrajchhetri-fix-test

Conversation

@tekrajchhetri

Copy link
Copy Markdown
Collaborator

Added additional paths to the codespell skip list (evaluation/benchmark,evaluation/pdf2reproschema/old,evaluation/ner/old,evaluation/pdf2reproschema/old/evaluation).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .pre-commit-config.yaml file to expand the list of paths that the codespell hook should skip. The feedback suggests that the path evaluation/pdf2reproschema/old/evaluation is redundant in the skip list, as codespell recursively skips subdirectories and evaluation/pdf2reproschema/old is already included. It is recommended to remove this redundant entry to simplify the configuration.

Comment thread .pre-commit-config.yaml
- id: codespell
args:
- --skip=poetry.lock,docs_style/pdoc-theme/syntax-highlighting.css,*.cha,*.ipynb,example/sample_metadata.csv
- --skip=poetry.lock,docs_style/pdoc-theme/syntax-highlighting.css,*.cha,*.ipynb,example/sample_metadata.csv,evaluation/benchmark,evaluation/pdf2reproschema/old,evaluation/ner/old,evaluation/pdf2reproschema/old/evaluation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The path evaluation/pdf2reproschema/old/evaluation is redundant because it is a subdirectory of evaluation/pdf2reproschema/old, which is already included in the skip list. codespell recursively skips content in specified directories, so the explicit inclusion of the subdirectory is not needed. Removing it will simplify the configuration.

    - --skip=poetry.lock,docs_style/pdoc-theme/syntax-highlighting.css,*.cha,*.ipynb,example/sample_metadata.csv,evaluation/benchmark,evaluation/pdf2reproschema/old,evaluation/ner/old

@tekrajchhetri
tekrajchhetri merged commit 78f6df3 into fix_json_op_issue Apr 9, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant