Fix GA workflow#63
Conversation
Summary of ChangesHello @djarecka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on stabilizing the GitHub Actions workflow by addressing installation errors. This was achieved through a comprehensive update and regeneration of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Code Review
This pull request updates the poetry.lock file to fix an issue with the test workflow. While many dependencies are updated, I've identified a critical issue with the environment markers for isodate and scipy. They have been restricted to Python 3.10 only, which will likely cause installation failures and ModuleNotFoundError on other supported Python versions (3.11, 3.12). This seems to be a side-effect of generating the lock file in a Python 3.10 environment and needs to be addressed to ensure the project works correctly across all supported Python versions.
| python-versions = ">=3.7" | ||
| groups = ["main"] | ||
| markers = "python_version < \"3.11\"" | ||
| markers = "python_version == \"3.10\"" |
There was a problem hiding this comment.
The environment marker for isodate has been restricted to only Python 3.10. Since this project supports Python versions up to 3.12 (>=3.10,<3.13), and isodate is a dependency of rdflib, this change will likely cause ModuleNotFoundError when running on Python 3.11 or 3.12. This marker seems incorrect and should probably be removed or corrected to allow isodate to be installed on all supported Python versions. This issue might stem from generating the lock file on a specific Python version.
There was a problem hiding this comment.
this is incorrect, the installation works for python 3.11 and 3.12
| python-versions = ">=3.10" | ||
| groups = ["main"] | ||
| markers = "python_version < \"3.11\"" | ||
| markers = "python_version == \"3.10\"" |
There was a problem hiding this comment.
The environment marker for this scipy package definition has been restricted to only Python 3.10. scipy is a dependency for pandas and should be available for all supported Python versions of the project (>=3.10,<3.13). This marker will prevent its installation on Python 3.11 and 3.12, potentially causing runtime errors. This marker should be reviewed to ensure scipy is correctly resolved for all target Python versions. It's possible this was caused by generating the lock file in a Python 3.10-only environment.
There was a problem hiding this comment.
this is incorrect, the installation works for python 3.11 and 3.12
There was a problem hiding this comment.
Pull request overview
Updates CI to resolve a GitHub Actions test workflow install failure by adjusting how Poetry is installed/cached, and refreshes the dependency lockfile accordingly.
Changes:
- Update the test workflow to install Poetry 2.3.2 and use
actions/setup-python’s built-in Poetry caching. - Remove an invalid/incorrectly placed
scheduletrigger from the workflow. - Regenerate
poetry.lockwith Poetry 2.3.2 (resulting in dependency/version and metadata updates).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
poetry.lock |
Regenerated lockfile using Poetry 2.3.2; updates resolved versions/markers and content hash. |
.github/workflows/test.yaml |
Adjusts Poetry installation and caching strategy in CI; removes the prior schedule stanza. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I've fixed the test workflow (it was giving an error during the installation) and I had to update
poetry.lockthe
pre-commit, the code has to be fixed in a different pr