Skip to content

Create 1.x branch #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 31 commits into
base: 1.x
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
7ae906e
chore: prepare 1.x
Jean-Beru Oct 3, 2024
b2ab0ad
fix(doc): annotations
Jean-Beru Apr 10, 2025
7fa23bf
Update doc generation
Neirda24 Apr 11, 2025
0fbfcf5
Better display list of see elements
Neirda24 Apr 11, 2025
7caceb8
Remove file taht should not be present
Neirda24 Apr 11, 2025
1bdb0b4
Add flatten in generation list
Neirda24 Apr 11, 2025
0236d6a
Fix rebase
Neirda24 Apr 11, 2025
1418184
fix(doc): annotations
Jean-Beru Apr 10, 2025
09b1b7b
Updates
Neirda24 Apr 11, 2025
5f82336
Update
Neirda24 Apr 11, 2025
1293ba8
fixes
Jean-Beru Apr 11, 2025
f369247
Merge branch '1.x' of github.com:Jean-Beru/GotenbergBundle into fix-r…
Neirda24 Apr 11, 2025
d2153c2
fixup
Neirda24 Apr 11, 2025
bb48f2a
update
Neirda24 Apr 11, 2025
d39c510
Update
Neirda24 Apr 12, 2025
ae24f6c
Update
Neirda24 Apr 12, 2025
34c6745
Update
Neirda24 Apr 12, 2025
13c303e
Update
Neirda24 Apr 12, 2025
cf075a5
Update
Neirda24 Apr 12, 2025
a50dccf
Update
Neirda24 Apr 12, 2025
95458ec
Update
Neirda24 Apr 12, 2025
96c0190
Fix doc (#2)
Jean-Beru Apr 14, 2025
360c622
Update docs/generate.php
Neirda24 Apr 15, 2025
f330fd2
update
Neirda24 Apr 15, 2025
c7392b3
fix: remove old tests
Jean-Beru Apr 15, 2025
e97e123
fix: tests
Jean-Beru Apr 15, 2025
a351634
fix: doc
Jean-Beru Apr 15, 2025
9f7e799
Fix compsoer dependency analyser
Neirda24 Apr 16, 2025
9f41d41
Add Service Subscriber Trait
StevenRenaux Apr 14, 2025
a9b00e2
Fix README for fonts
StevenRenaux Apr 23, 2025
c8c9737
Remove autowire & hack symfony
Neirda24 Apr 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
/bin export-ignore
/docs export-ignore
/tests export-ignore
/.php-cs-fixer.dist.php export-ignore
/composer-dependency-analyser.php export-ignore
/phpstan.neon export-ignore
/phpunit.xml export-ignore
/.git* export-ignore
1 change: 1 addition & 0 deletions .php-cs-fixer.dist.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

$finder = (new PhpCsFixer\Finder())
->in([
__DIR__ . '/bin',
__DIR__ . '/config',
__DIR__ . '/docs',
__DIR__ . '/src',
Expand Down
9 changes: 1 addition & 8 deletions .phpstorm.meta.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,7 @@

namespace PHPSTORM_META {
expectedArguments(
\Sensiolabs\GotenbergBundle\Builder\Pdf\AbstractPdfBuilder::fileName(),
1,
\Symfony\Component\HttpFoundation\HeaderUtils::DISPOSITION_INLINE,
\Symfony\Component\HttpFoundation\HeaderUtils::DISPOSITION_ATTACHMENT,
);

expectedArguments(
\Sensiolabs\GotenbergBundle\Builder\Screenshot\AbstractScreenshotBuilder::fileName(),
\Sensiolabs\GotenbergBundle\Builder\AbstractBuilder::fileName(),
1,
\Symfony\Component\HttpFoundation\HeaderUtils::DISPOSITION_INLINE,
\Symfony\Component\HttpFoundation\HeaderUtils::DISPOSITION_ATTACHMENT,
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,8 @@ class YourController
6. [Merge Builder](./docs/pdf/merge-builder.md)
7. [Convert Builder](./docs/pdf/convert-builder.md)
8. [Split Builder](./docs/pdf/split-builder.md)
9. [PDF customization](./docs/pdf/customization.md) (available for every builder except LibreOffice, Merge and Split)
9. [Flatten Builder](./docs/pdf/flatten-builder.md)
10. [PDF customization](./docs/pdf/customization.md) (available for HTML, Markdown and Url builder)

#### Screenshot

Expand Down
23 changes: 23 additions & 0 deletions bin/config.dump-reference
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/usr/bin/env php
<?php

use Sensiolabs\GotenbergBundle\DependencyInjection\SensiolabsGotenbergExtension;
use Sensiolabs\GotenbergBundle\SensiolabsGotenbergBundle;
use Symfony\Component\Config\Definition\Dumper\YamlReferenceDumper;
use Symfony\Component\DependencyInjection\ContainerBuilder;

require dirname(__DIR__).'/vendor/autoload.php';

$yamlDumper = new YamlReferenceDumper();

$containerBuilder = new ContainerBuilder();
$gotenbergBundle = new SensiolabsGotenbergBundle();

$containerBuilder->registerExtension($gotenbergBundle->getContainerExtension());

$gotenbergBundle->build($containerBuilder);

/** @var SensiolabsGotenbergExtension $gotenbergExtension */
$gotenbergExtension = $containerBuilder->getExtension('sensiolabs_gotenberg');

echo $yamlDumper->dump($gotenbergExtension->getConfiguration([], $containerBuilder));
1 change: 1 addition & 0 deletions composer-dependency-analyser.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
$config = new Configuration();

return $config
->addPathToScan(__DIR__.'/bin', isDev: true)
->addPathToScan(__DIR__.'/src', isDev: false)
->addPathToScan(__DIR__.'/src/DataCollector', isDev: true)
->addPathToScan(__DIR__.'/src/Debug', isDev: true)
Expand Down
3 changes: 3 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
],
"require": {
"php": ">=8.1",
"ext-json": "*",
"psr/container": "^2.0",
"psr/log": "^3.0",
"symfony/config": "^6.4 || ^7.0",
Expand Down Expand Up @@ -49,6 +50,7 @@
"symfony/stopwatch": "^6.4 || ^7.0",
"symfony/twig-bundle": "^6.4 || ^7.0",
"symfony/var-dumper": "^6.4 || ^7.0",
"symfony/yaml": "^6.4 || ^7.0",
"twig/twig": "^3.14"
},
"config": {
Expand All @@ -59,6 +61,7 @@
},
"suggest": {
"symfony/monolog-bundle": "Enables logging througout the generating process.",
"symfony/routing": "Allows you to use webhook to generate URL or route.",
"symfony/twig-bundle": "Allows you to use Twig to render templates into PDF.",
"monolog/monolog": "Enables logging througout the generating process.",
"async-aws/s3": "Upload any file to aws s3 compatible endpoints supporting multi part upload without memory overhead.",
Expand Down
38 changes: 38 additions & 0 deletions config/builder.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<?php

use Sensiolabs\GotenbergBundle\Builder\AbstractBuilder;
use Sensiolabs\GotenbergBundle\Configurator\BuilderConfigurator;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use function Symfony\Component\DependencyInjection\Loader\Configurator\abstract_arg;
use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
use function Symfony\Component\DependencyInjection\Loader\Configurator\service_locator;

return static function (ContainerConfigurator $container): void {
$services = $container->services();

$services->defaults()
->tag('monolog.logger', ['channel' => 'sensiolabs_gotenberg'])
;

$services->set('.sensiolabs_gotenberg.abstract_builder', AbstractBuilder::class)
->abstract()
->args([
service('sensiolabs_gotenberg.client'),
service_locator([
'asset_base_dir_formatter' => service('.sensiolabs_gotenberg.asset.base_dir_formatter'),
'webhook_configuration_registry' => service('.sensiolabs_gotenberg.webhook_configuration_registry'),
'logger' => service('logger')->nullOnInvalid(),
'request_stack' => service('request_stack')->nullOnInvalid(),
'router' => service('router.default')->nullOnInvalid(),
'twig' => service('twig')->nullOnInvalid(),
]),
])
;

$services->set('sensiolabs_gotenberg.builder_configurator', BuilderConfigurator::class)
->args([
abstract_arg('Mapping of methods per builder for each configuration key'),
abstract_arg('Mapping of values per builder for each configuration key'),
])
;
};
93 changes: 37 additions & 56 deletions config/builder_pdf.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?php

use Sensiolabs\GotenbergBundle\Builder\Pdf\ConvertPdfBuilder;
use Sensiolabs\GotenbergBundle\Builder\Pdf\FlattenPdfBuilder;
use Sensiolabs\GotenbergBundle\Builder\Pdf\HtmlPdfBuilder;
use Sensiolabs\GotenbergBundle\Builder\Pdf\LibreOfficePdfBuilder;
use Sensiolabs\GotenbergBundle\Builder\Pdf\MarkdownPdfBuilder;
Expand All @@ -17,88 +18,68 @@
->tag('monolog.logger', ['channel' => 'sensiolabs_gotenberg'])
;

// HTML
$services->set('.sensiolabs_gotenberg.pdf_builder.html', HtmlPdfBuilder::class)
->share(false)
->args([
service('sensiolabs_gotenberg.client'),
service('.sensiolabs_gotenberg.asset.base_dir_formatter'),
service('.sensiolabs_gotenberg.webhook_configuration_registry'),
service('request_stack'),
service('twig')->nullOnInvalid(),
])
->call('setLogger', [service('logger')->nullOnInvalid()])
->tag('sensiolabs_gotenberg.pdf_builder')
->parent('.sensiolabs_gotenberg.abstract_builder')
->tag('sensiolabs_gotenberg.builder')
->configurator(service('sensiolabs_gotenberg.builder_configurator'))
;

// URL
$services->set('.sensiolabs_gotenberg.pdf_builder.url', UrlPdfBuilder::class)
->share(false)
->args([
service('sensiolabs_gotenberg.client'),
service('.sensiolabs_gotenberg.asset.base_dir_formatter'),
service('.sensiolabs_gotenberg.webhook_configuration_registry'),
service('request_stack'),
service('twig')->nullOnInvalid(),
service('router')->nullOnInvalid(),
])
->call('setLogger', [service('logger')->nullOnInvalid()])
->parent('.sensiolabs_gotenberg.abstract_builder')
->tag('sensiolabs_gotenberg.builder')
->configurator(service('sensiolabs_gotenberg.builder_configurator'))
->call('setRequestContext', [service('.sensiolabs_gotenberg.request_context')->nullOnInvalid()])
->tag('sensiolabs_gotenberg.pdf_builder')
;

// Markdown
$services->set('.sensiolabs_gotenberg.pdf_builder.markdown', MarkdownPdfBuilder::class)
->share(false)
->args([
service('sensiolabs_gotenberg.client'),
service('.sensiolabs_gotenberg.asset.base_dir_formatter'),
service('.sensiolabs_gotenberg.webhook_configuration_registry'),
service('request_stack'),
service('twig')->nullOnInvalid(),
])
->call('setLogger', [service('logger')->nullOnInvalid()])
->tag('sensiolabs_gotenberg.pdf_builder')
->parent('.sensiolabs_gotenberg.abstract_builder')
->tag('sensiolabs_gotenberg.builder')
->configurator(service('sensiolabs_gotenberg.builder_configurator'))
;

// Office
$services->set('.sensiolabs_gotenberg.pdf_builder.office', LibreOfficePdfBuilder::class)
->share(false)
->args([
service('sensiolabs_gotenberg.client'),
service('.sensiolabs_gotenberg.asset.base_dir_formatter'),
service('.sensiolabs_gotenberg.webhook_configuration_registry'),
])
->call('setLogger', [service('logger')->nullOnInvalid()])
->tag('sensiolabs_gotenberg.pdf_builder')
->parent('.sensiolabs_gotenberg.abstract_builder')
->tag('sensiolabs_gotenberg.builder')
->configurator(service('sensiolabs_gotenberg.builder_configurator'))
;

// Merge
$services->set('.sensiolabs_gotenberg.pdf_builder.merge', MergePdfBuilder::class)
->share(false)
->args([
service('sensiolabs_gotenberg.client'),
service('.sensiolabs_gotenberg.asset.base_dir_formatter'),
service('.sensiolabs_gotenberg.webhook_configuration_registry'),
])
->call('setLogger', [service('logger')->nullOnInvalid()])
->tag('sensiolabs_gotenberg.pdf_builder')
->parent('.sensiolabs_gotenberg.abstract_builder')
->tag('sensiolabs_gotenberg.builder')
->configurator(service('sensiolabs_gotenberg.builder_configurator'))
;

// Convert
$services->set('.sensiolabs_gotenberg.pdf_builder.convert', ConvertPdfBuilder::class)
->share(false)
->args([
service('sensiolabs_gotenberg.client'),
service('.sensiolabs_gotenberg.asset.base_dir_formatter'),
service('.sensiolabs_gotenberg.webhook_configuration_registry'),
])
->call('setLogger', [service('logger')->nullOnInvalid()])
->tag('sensiolabs_gotenberg.pdf_builder')
->parent('.sensiolabs_gotenberg.abstract_builder')
->tag('sensiolabs_gotenberg.builder')
->configurator(service('sensiolabs_gotenberg.builder_configurator'))
;

// Split
$services->set('.sensiolabs_gotenberg.pdf_builder.split', SplitPdfBuilder::class)
->share(false)
->args([
service('sensiolabs_gotenberg.client'),
service('.sensiolabs_gotenberg.asset.base_dir_formatter'),
service('.sensiolabs_gotenberg.webhook_configuration_registry'),
])
->call('setLogger', [service('logger')->nullOnInvalid()])
->tag('sensiolabs_gotenberg.pdf_builder')
->parent('.sensiolabs_gotenberg.abstract_builder')
->tag('sensiolabs_gotenberg.builder')
->configurator(service('sensiolabs_gotenberg.builder_configurator'))
;

// Flatten
$services->set('.sensiolabs_gotenberg.pdf_builder.flatten', FlattenPdfBuilder::class)
->share(false)
->parent('.sensiolabs_gotenberg.abstract_builder')
->tag('sensiolabs_gotenberg.builder')
->configurator(service('sensiolabs_gotenberg.builder_configurator'))
;
};
46 changes: 15 additions & 31 deletions config/builder_screenshot.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,44 +13,28 @@
->tag('monolog.logger', ['channel' => 'sensiolabs_gotenberg'])
;

// HTML
$services->set('.sensiolabs_gotenberg.screenshot_builder.html', HtmlScreenshotBuilder::class)
->share(false)
->args([
service('sensiolabs_gotenberg.client'),
service('.sensiolabs_gotenberg.asset.base_dir_formatter'),
service('.sensiolabs_gotenberg.webhook_configuration_registry'),
service('request_stack'),
service('twig')->nullOnInvalid(),
])
->call('setLogger', [service('logger')->nullOnInvalid()])
->tag('sensiolabs_gotenberg.screenshot_builder')
->parent('.sensiolabs_gotenberg.abstract_builder')
->tag('sensiolabs_gotenberg.builder')
->configurator(service('sensiolabs_gotenberg.builder_configurator'))
;

$services->set('.sensiolabs_gotenberg.screenshot_builder.url', UrlScreenshotBuilder::class)
// Markdown
$services->set('.sensiolabs_gotenberg.screenshot_builder.markdown', MarkdownScreenshotBuilder::class)
->share(false)
->args([
service('sensiolabs_gotenberg.client'),
service('.sensiolabs_gotenberg.asset.base_dir_formatter'),
service('.sensiolabs_gotenberg.webhook_configuration_registry'),
service('request_stack'),
service('twig')->nullOnInvalid(),
service('router')->nullOnInvalid(),
])
->call('setLogger', [service('logger')->nullOnInvalid()])
->call('setRequestContext', [service('.sensiolabs_gotenberg.request_context')->nullOnInvalid()])
->tag('sensiolabs_gotenberg.screenshot_builder')
->parent('.sensiolabs_gotenberg.abstract_builder')
->tag('sensiolabs_gotenberg.builder')
->configurator(service('sensiolabs_gotenberg.builder_configurator'))
;

$services->set('.sensiolabs_gotenberg.screenshot_builder.markdown', MarkdownScreenshotBuilder::class)
// URL
$services->set('.sensiolabs_gotenberg.screenshot_builder.url', UrlScreenshotBuilder::class)
->share(false)
->args([
service('sensiolabs_gotenberg.client'),
service('.sensiolabs_gotenberg.asset.base_dir_formatter'),
service('.sensiolabs_gotenberg.webhook_configuration_registry'),
service('request_stack'),
service('twig')->nullOnInvalid(),
])
->call('setLogger', [service('logger')->nullOnInvalid()])
->tag('sensiolabs_gotenberg.screenshot_builder')
->parent('.sensiolabs_gotenberg.abstract_builder')
->tag('sensiolabs_gotenberg.builder')
->configurator(service('sensiolabs_gotenberg.builder_configurator'))
->call('setRequestContext', [service('.sensiolabs_gotenberg.request_context')->nullOnInvalid()])
;
};
11 changes: 10 additions & 1 deletion config/debug.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?php

use Sensiolabs\GotenbergBundle\DataCollector\GotenbergDataCollector;
use Sensiolabs\GotenbergBundle\Debug\Client\TraceableGotenbergClient;
use Sensiolabs\GotenbergBundle\Debug\TraceableGotenbergPdf;
use Sensiolabs\GotenbergBundle\Debug\TraceableGotenbergScreenshot;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
Expand All @@ -26,11 +27,19 @@
])
;

$services->set('sensiolabs_gotenberg.traceable_client', TraceableGotenbergClient::class)
->decorate('sensiolabs_gotenberg.client')
->args([
new Reference('.inner'),
])
;

$services->set('sensiolabs_gotenberg.data_collector', GotenbergDataCollector::class)
->args([
service('sensiolabs_gotenberg.pdf'),
service('sensiolabs_gotenberg.screenshot'),
tagged_locator('sensiolabs_gotenberg.pdf_builder'),
tagged_locator('sensiolabs_gotenberg.builder'),
service('sensiolabs_gotenberg.client'),
abstract_arg('All default options will be set through the configuration.'),
])
->tag('data_collector', ['template' => '@SensiolabsGotenberg/Collector/sensiolabs_gotenberg.html.twig', 'id' => 'sensiolabs_gotenberg'])
Expand Down
5 changes: 2 additions & 3 deletions config/services.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
use function Symfony\Component\DependencyInjection\Loader\Configurator\param;
use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
use function Symfony\Component\DependencyInjection\Loader\Configurator\service_locator;
use function Symfony\Component\DependencyInjection\Loader\Configurator\tagged_locator;

return static function (ContainerConfigurator $container): void {
$services = $container->services();
Expand Down Expand Up @@ -47,14 +46,14 @@

$services->set('sensiolabs_gotenberg.pdf', GotenbergPdf::class)
->args([
tagged_locator('sensiolabs_gotenberg.pdf_builder'),
abstract_arg('PDF builders services'),
])
->alias(GotenbergPdfInterface::class, 'sensiolabs_gotenberg.pdf')
;

$services->set('sensiolabs_gotenberg.screenshot', GotenbergScreenshot::class)
->args([
tagged_locator('sensiolabs_gotenberg.screenshot_builder'),
abstract_arg('Screenshot builders services'),
])
->alias(GotenbergScreenshotInterface::class, 'sensiolabs_gotenberg.screenshot')
;
Expand Down
1 change: 1 addition & 0 deletions docs/builders_api.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Pdf

* [ConvertPdfBuilder](./pdf/builders_api/ConvertPdfBuilder.md)
* [FlattenPdfBuilder](./pdf/builders_api/FlattenPdfBuilder.md)
* [HtmlPdfBuilder](./pdf/builders_api/HtmlPdfBuilder.md)
* [LibreOfficePdfBuilder](./pdf/builders_api/LibreOfficePdfBuilder.md)
* [MarkdownPdfBuilder](./pdf/builders_api/MarkdownPdfBuilder.md)
Expand Down
Loading